Give the same-origin path check a single home - #1236
Merged
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 7 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark Index (community)
Details
| Benchmark suite | Current: 3fe70a5 | Previous: 5b2b37f | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
336 ms |
336 ms |
1 |
Add one schema (100 existing) |
38 ms |
46 ms |
0.83 |
Add one schema (1000 existing) |
93 ms |
99 ms |
0.94 |
Add one schema (10000 existing) |
725 ms |
778 ms |
0.93 |
Update one schema (1 existing) |
28 ms |
29 ms |
0.97 |
Update one schema (101 existing) |
45 ms |
41 ms |
1.10 |
Update one schema (1001 existing) |
97 ms |
107 ms |
0.91 |
Update one schema (10001 existing) |
859 ms |
800 ms |
1.07 |
Cached rebuild (1 existing) |
10 ms |
11 ms |
0.91 |
Cached rebuild (101 existing) |
12 ms |
15 ms |
0.80 |
Cached rebuild (1001 existing) |
40 ms |
47 ms |
0.85 |
Cached rebuild (10001 existing) |
381 ms |
315 ms |
1.21 |
Index 100 schemas |
560 ms |
657 ms |
0.85 |
Index 1000 schemas |
1447 ms |
1524 ms |
0.95 |
Index 10000 schemas |
12898 ms |
13088 ms |
0.99 |
Index 10000 schemas (custom meta-schema) |
15142 ms |
15701 ms |
0.96 |
Index 10000 schemas ($ref fan-out) |
15404 ms |
15791 ms |
0.98 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Benchmark Index (enterprise)
Details
| Benchmark suite | Current: 3fe70a5 | Previous: 5b2b37f | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
367 ms |
392 ms |
0.94 |
Add one schema (100 existing) |
121 ms |
114 ms |
1.06 |
Add one schema (1000 existing) |
175 ms |
170 ms |
1.03 |
Add one schema (10000 existing) |
784 ms |
730 ms |
1.07 |
Update one schema (1 existing) |
117 ms |
106 ms |
1.10 |
Update one schema (101 existing) |
124 ms |
120 ms |
1.03 |
Update one schema (1001 existing) |
180 ms |
168 ms |
1.07 |
Update one schema (10001 existing) |
806 ms |
752 ms |
1.07 |
Cached rebuild (1 existing) |
13 ms |
12 ms |
1.08 |
Cached rebuild (101 existing) |
15 ms |
15 ms |
1 |
Cached rebuild (1001 existing) |
49 ms |
42 ms |
1.17 |
Cached rebuild (10001 existing) |
345 ms |
298 ms |
1.16 |
Index 100 schemas |
468 ms |
567 ms |
0.83 |
Index 1000 schemas |
1507 ms |
1519 ms |
0.99 |
Index 10000 schemas |
12618 ms |
12788 ms |
0.99 |
Index 10000 schemas (custom meta-schema) |
14957 ms |
15872 ms |
0.94 |
Index 10000 schemas ($ref fan-out) |
15159 ms |
15685 ms |
0.97 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com