fix: surface errors from lazily loaded route modules instead of hanging the SSR stream - #2259
Closed
birkskyum wants to merge 4 commits into
Closed
fix: surface errors from lazily loaded route modules instead of hanging the SSR stream#2259birkskyum wants to merge 4 commits into
birkskyum wants to merge 4 commits into
Conversation
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🦋 Changeset detectedLatest commit: 380008c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Member
|
perhaps we can move this as an upstream issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A syntax error in a route (or anything it imports) left the browser on a blank page with no error shown anywhere.
Every file route loads through
lazy(). When the module fails to transform, its dynamic import rejects, and Solid's server-sidelazyhas no rejection path:So
_loadingstays true, the Suspense boundary never resolves, andrenderToStreamnever closes. The document shell is flushed and the connection then hangs open forever, which is also why no Vite overlay appears: as far as the browser is concerned the page loaded fine.withAssetsalready wraps the import on the server for asset collection, so this catches the rejection there and returns a module that throws during render. Solid routes that throughcatchErrorto the nearestErrorBoundary, i.e. the dev overlay. Also covers a lazy chunk failing to load in production, which hung the stream the same way.Errors in eagerly imported files (
app.tsx,entry-server.tsx) were already handled and are unchanged.Verified on
apps/fixtures/basicwith a broken component:Added
lazy.spec.ts, which times out with "the SSR stream never closed" without the fix.