WIP: Upgrade to solid 2 beta#2091
Draft
brenelz wants to merge 29 commits into
Draft
Conversation
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
commit: |
brenelz
commented
Mar 4, 2026
| useAssets_(() => renderAsset(asset, nonce)); | ||
| entity.ssrIdx = ssrRequestAssets.length - 1; | ||
| useAssets_(() => renderAsset(asset, nonce) as any); | ||
| if (ssrRequestAssets) { |
Contributor
Author
There was a problem hiding this comment.
im not sure if these changes are correct or needed
brenelz
commented
Mar 4, 2026
| // used on native HTML elements during SSR transformation. The previous | ||
| // implementation used JSX (<style {...props.attrs}> etc.) which triggered the | ||
| // bug. Instead we build the HTML strings directly — these assets are only | ||
| // ever rendered during SSR so reactive JSX is unnecessary. |
Contributor
Author
There was a problem hiding this comment.
these changes are probably unneeded
Contributor
Author
There was a problem hiding this comment.
seems that they are needed in some capacity
brenelz
commented
Mar 4, 2026
brenelz
commented
Mar 7, 2026
brenelz
commented
Mar 7, 2026
lxsmnsyc
reviewed
Mar 9, 2026
Member
|
We can probably use |
Member
|
needs rebasing |
- Update leftover accessor-style children callbacks to beta.15 semantics: non-keyed <For> and keyed <Show> now pass raw values, not accessors (notes, hackernews, todomvc fixtures + one missed spot in the dev overlay) - Patch terracotta to shim removed @solidjs/web createDynamic export - Align @solidjs/signals in apps/tests with solid-js 2.0.0-beta.15 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
# Conflicts: # apps/tests/vite.config.ts # packages/start/package.json # packages/start/src/config/index.ts # packages/start/src/fns/handler.ts # packages/start/src/fns/server.ts # packages/start/src/server/handler.ts # pnpm-lock.yaml
- onSettled no longer accepts async callbacks (a returned Promise is an invalid cleanup value) — wrap the async work in a void IIFE across the test routes, and convert main's new server-env route from createEffect(async) to the same pattern - dev overlay: Errored's fallback now receives an accessor, and signal writes inside the boundary's owned scope throw — read the error and defer the push to a microtask Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
In Solid 2, createEffect's compute runs during SSR, so the export check executed on the server — where the "use server" module legitimately still exports testQuery — baking "true" into the markup. Use onSettled (a server no-op) like the other server-function routes so the check runs against the client module, where non-function exports are stripped. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
terracotta next.6 migrated to solid 2.0.0-beta.15 (own createDynamic helper, JSX types from @solidjs/web), so the pnpm patch shimming the removed @solidjs/web createDynamic export is no longer needed, and the dev overlay's Select props no longer need the `as any` cast. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Seeing what It take to update SolidStart to use Solid 2.0 beta. The examples work even with solid-router