Skip to content

fix: lazy init of audio engine - #1251

Merged
maciejmakowski2003 merged 2 commits into
mainfrom
refactor/lazy-audio-engine-init
Aug 25, 2026
Merged

fix: lazy init of audio engine#1251
maciejmakowski2003 merged 2 commits into
mainfrom
refactor/lazy-audio-engine-init

Conversation

@maciejmakowski2003

Copy link
Copy Markdown
Collaborator

⚠️ Breaking changes ⚠️

  • Removed AudioEngine allocation inside iOS audio-api module installation and restricted AudioEngine rebuild - apps that use react-native-audio-api only for session / notification management should not be forced to allocate it.
  • Restricted session activation on media services reset - the audio session should not be activated after that notification if it had not been active beforehand.

Introduced changes

  • Fixed typo in SystemNotificationManager.mm - handleEngineConfigurationChange was not invoked.

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code
  • Updated Web Audio API coverage
  • Added support for web
  • Updated old arch android spec file

@maciejmakowski2003 maciejmakowski2003 added the fix Code changes specifically addressing and resolving a bug label Aug 24, 2026
@github-actions

github-actions Bot commented Aug 24, 2026

Copy link
Copy Markdown

WPT non-regression comparison

PASS — no regressions · 0 improved section(s) · overall 2632 → 2632 (0)

Unchanged sections (28)
Spec section Base pass Head pass Delta
Processing model 0 0 0
Other 52 52 0
AnalyserNode 138 138 0
AudioBuffer 140 140 0
AudioBufferSourceNode 208 208 0
AudioContext 58 58 0
AudioNode 261 261 0
AudioParam 599 599 0
BiquadFilterNode 275 275 0
ChannelMergerNode 30 30 0
ChannelSplitterNode 7 7 0
ConstantSourceNode 59 59 0
ConvolverNode 170 170 0
DelayNode 104 104 0
DestinationNode 0 0 0
DynamicsCompressorNode 4 4 0
GainNode 15 15 0
IIRFilterNode 87 87 0
MediaElementAudioSourceNode 0 0 0
MediaStreamAudioDestinationNode 1 1 0
MediaStreamAudioSourceNode 0 0 0
OfflineAudioContext 35 35 0
OscillatorNode 104 104 0
PannerNode 75 75 0
PeriodicWave 33 33 0
ScriptProcessorNode 0 0 0
StereoPannerNode 102 102 0
WaveShaperNode 75 75 0

Baseline: f8b57cd46198e0612871fa0f68b27fd7099eec53 · Candidate: 698d4c3385a87d01b3f093ccd4d4da90def07bf1

Workflow run · this comment is updated on every push.

@maciejmakowski2003
maciejmakowski2003 merged commit 77a9d5c into main Aug 25, 2026
12 checks passed
@maciejmakowski2003
maciejmakowski2003 deleted the refactor/lazy-audio-engine-init branch August 25, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Code changes specifically addressing and resolving a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants