[Example] Add a scene checking the projection of mapped matrices - #6262
Open
fredroy wants to merge 5 commits into
Open
[Example] Add a scene checking the projection of mapped matrices#6262fredroy wants to merge 5 commits into
fredroy wants to merge 5 commits into
Conversation
alxbilger
reviewed
Aug 26, 2026
Contributor
|
Excellent idea to have this scene. I thought I had something similar somewhere. There is Can Claude translate it to a C++ unit test? I also would like to apply this test on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude:
Adds a self-checking example for the assembly of force fields acting on mapped states.
The scene runs the same mechanical system twice: once with a spring acting directly on two top-level states, once with the same spring acting on two identity-mapped children. Since J = I, the projected matrix JTKJ must equal K, so both sub-trees must follow exactly the same trajectory.
A WriteState on each top-level state records the result, and the two files must be identical.
This test is intended to show the validity of #6256 .
The mapped positions are supposed to be identical with the "direct" positions but with master it does not. (and it does with #6256)
directP1.xmappedQ1.x( I did the tests by myself 👀)
The output files does serve as a self-contained regression test but it can be added as a regular regression test as well.
EDIT: converted to unit tests, with the following combinations:
FullMatrixMatrixLinearSystemMatrixProjectionMethodFullMatrixMatrixLinearSystemConstantSparsityProjectionMethodCompressedRowSparseMatrixdMatrixLinearSystemMatrixProjectionMethodCompressedRowSparseMatrixdMatrixLinearSystemConstantSparsityProjectionMethodCompressedRowSparseMatrixdConstantSparsityPatternSystemMatrixProjectionMethodCompressedRowSparseMatrixdConstantSparsityPatternSystemConstantSparsityProjectionMethodBy submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if