Dynamic client fixes - #1328
Merged
Merged
Conversation
Use ServiceIndex.getEffectiveAuthSchemes(service, operation, NO_AUTH_AWARE) so @auth overrides, @auth([]), and @optionalAuth are honored, and register all service auth schemes (getAuthSchemes) during detection. A service that models no auth now resolves to noAuth like a code-generated client; update SmithyCallTest accordingly.
Attach a builder supplier to dynamic struct/union schemas so Schema#shapeBuilder() works off a runtime model, letting the AWS event decoder build event variants on the dynamic path. Run the event-stream client protocol tests in dynamic mode and fix the DynamicClient javadoc.
mtdowling
force-pushed
the
dynamic-client-fixes
branch
from
August 17, 2026 21:12
b4fea1b to
38aa34c
Compare
sugmanue
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What behavior changes?
Describe the observable difference in behavior before and after this change.
DynamicClient gains two capabilities:
@authoverrides,@auth([])(no-auth), and@optionalAuthare honored, matching what a code-generated client does. Auth-scheme detection now registers all schemes defined on the service, not just the service default.@streamingunion event streams (input, output, and bidirectional). Previously, decoding an output event stream on the dynamic path threw IllegalStateException: Schema does not have a shape builder; now each event variant is built from the runtime model as a schema-backed document. The DynamicClient javadoc no longer claims streaming is unsupported.Why is this change needed?
Explain the motivation: bug, feature request, refactor, performance, etc.
@auth/@optionalAuth/@auth([])operations were signed incorrectly or over-broadly.How was this validated?
List tests added, benchmarks run, or manual verification performed.
Tests and also live calls to BedRock.
What should reviewers focus on?
Point reviewers to the files or sections that contain the interesting logic.
Additional Links
Related issues, design docs, or prior art.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.