CRE-6535: remove unused web-api-trigger/target gateway handler code - #23728
Open
bolekk wants to merge 2 commits into
Open
CRE-6535: remove unused web-api-trigger/target gateway handler code#23728bolekk wants to merge 2 commits into
bolekk wants to merge 2 commits into
Conversation
Contributor
CORA - Pending Reviewers
Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown For more details, see the full review summary. |
Contributor
|
I see you updated files related to
|
Contributor
|
✅ No conflicts with other open PRs targeting |
|
|
Removes the legacy web_api_trigger/web_api_target methods and their supporting node- and gateway-side code, now that these capabilities have no live deployment path (superseded by http-trigger/http-action). - Deletes core/capabilities/webapi/trigger, .../target, and the webapicap schema/generated types that only they used - Deletes the standalone dev scripts for invoking the trigger - Strips MethodWebAPITrigger/MethodWebAPITarget handling, the legacy callback-pruning machinery, and HandleLegacyUserMessage's trigger logic from the gateway capabilities handler (compute_action and workflow_syncer, used by V2 artifact fetching, are untouched) - Drops the __builtin_web-api-trigger/target wiring from the standardcapabilities delegate - Removes the WebAPITrigger/WebAPITarget job-spec template types from deployment/cre/jobs - go mod tidy (both modules) to drop go-jsonschema and other deps that were only pulled in by the deleted webapicap generator Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
bolekk
force-pushed
the
worktree-cre-6535-deprecate-webapi-handler
branch
from
September 13, 2026 02:08
031b498 to
c1458d0
Compare
|
bolekk
marked this pull request as ready for review
September 13, 2026 02:51
product-security-plaid-production
Bot
requested review from
graham-chainlink,
justinkaseman and
kalverra
September 13, 2026 02:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the legacy web_api_trigger/web_api_target methods and their supporting node- and gateway-side code, now that these capabilities have no live deployment path (superseded by http-trigger/http-action).
NOTE: This handler is still used for workflow artifact fetching. The next step is to migrate that functionality into the HTTP handler.
https://smartcontract-it.atlassian.net/browse/CRE-6535
Deployment Validation: