Conversation
|
1cfb5ef to
7e496f7
Compare
nolag
left a comment
nolag
left a comment
There was a problem hiding this comment.
Up to you to address my comments or not. I'm ok with the breaking change given we want to burn this bridge, but also get that we can leave a couple few and not worry about compliation.
| type ModuleBase interface { | ||
| Start() | ||
| Close() | ||
| IsLegacyDAG() bool |
There was a problem hiding this comment.
Should we just return false and make it a non-breaking change?
| } | ||
|
|
||
| // Run is deprecated, use execute instead | ||
| func (m *module) Run(ctx context.Context, request *wasmdagpb.Request) (*wasmdagpb.Response, error) { |
There was a problem hiding this comment.
If we want "non-breaking" for the interface, we can return an error saying we no longer run these.
9870d9f to
d787e16
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 22538eb | Previous: 525697c | Ratio |
|---|---|---|---|
BenchmarkKeystore_Sign/nop/in-process |
820.6 ns/op |
350.1 ns/op |
2.34 |
This comment was automatically generated by workflow using github-action-benchmark.
d787e16 to
db24ccb
Compare
Strips the v1 legacy DAG machinery from the wasm host ahead of the DAG WASM removal (CRE-5836): ModuleV1/Run, linkLegacyDAG, IsLegacyDAG, GetWorkflowSpec, the legacy fetch/emit/log env imports and converters, the determinism random_get shim, the legacy poll_oneoff stub and fake clock, and the Fetch/MaxFetchRequests/Labeler/Determinism module config fields. IsLegacyDAG is also dropped from host.ModuleBase. The sleep/oom test drivers are ported to v2 guests (rawsdk import) and driven via Execute, the two brotli/size tests are kept, and the 13 legacy guest test modules plus the dead test/requirements fixtures, mocks/module_v1 and its .mockery.yaml entry are deleted.
db24ccb to
22538eb
Compare
3 participants
Strips the v1 legacy DAG machinery from the wasm host ahead of the DAG WASM removal (CRE-5836): ModuleV1/Run, linkLegacyDAG, IsLegacyDAG, GetWorkflowSpec, the legacy fetch/emit/log env imports and converters, the determinism random_get shim, the legacy poll_oneoff stub and fake clock, and the Fetch/MaxFetchRequests/Labeler/Determinism module config fields. IsLegacyDAG is also dropped from host.ModuleBase.
The sleep/oom test drivers are ported to v2 guests (rawsdk import) and driven via Execute, the two brotli/size tests are kept, and the 13 legacy guest test modules plus the dead test/requirements fixtures, mocks/module_v1 and its .mockery.yaml entry are deleted.
See full plan in https://docs.google.com/document/d/1pRJ8zXt7Z_skqksG7-yRoa6v7pMEbZ7jmhu5DybaI6s/edit?usp=sharing
Deployment Validation: Existing Canaries.