fix(resources): make context menus selection-aware - #6980
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview Covers tables, knowledge bases, folders, files, documents, chunks, workflows, and chats. Document menus use the select-all total (not just the current page) and avoid overstating toggle counts when the affected subset is unknown. Read-only multi-folder selections show No actions available. Reviewed by Cursor Bugbot for commit 3d5fb83. Configure here. |
Greptile SummaryThe PR makes resource context menus reflect the current selection and suppresses actions that only apply to a single item.
Confidence Score: 5/5The PR appears safe to merge because no eligible blocking failure remains. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/sim/app/workspace/[workspaceId]/components/resource/selection-label.ts | Centralizes singular, bulk, and enable/disable action-label formatting. |
| apps/sim/app/workspace/[workspaceId]/knowledge/[id]/base.tsx | Integrates select-all counts and toggle-count precision into document context-menu and confirmation flows. |
| apps/sim/app/workspace/[workspaceId]/components/folders/folder-context-menu.tsx | Hides single-folder actions for group selections and labels supported bulk actions. |
| apps/sim/app/workspace/[workspaceId]/tables/components/table-context-menu/table-context-menu.tsx | Limits multi-table menus to selection-capable operations and applies shared labels. |
| apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/workflow-list/components/context-menu/context-menu.tsx | Adds selection-aware labels for workflow and folder duplicate, export, and delete operations. |
| apps/sim/app/workspace/[workspaceId]/components/resource/selection-aware-context-menus.test.tsx | Covers action visibility and labels across resource-menu multi-selection states. |
Reviews (4): Last reviewed commit: "fix(knowledge): keep select-all actions ..." | Re-trigger Greptile
15a3de2 to
756cf45
Compare
|
@cursor review |
756cf45 to
3d570de
Compare
|
@cursor review |
3d570de to
3d5fb83
Compare
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 3d5fb83. Configure here.
Summary
Type of Change
Testing
Checklist