fix: add attach error status mode - #401
Draft
hyang214 wants to merge 1 commit into
Draft
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
ethanpailes
approved these changes
Jul 20, 2026
ethanpailes
left a comment
Contributor
There was a problem hiding this comment.
This looks mergable as is. Thanks!
Let's see if CI is happy.
Contributor
|
Looks like we'll need a CLA sig before we can merge. |
Contributor
|
Oh, one nit: this is a feature not a bugfix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--error-status-mode shell|attachtoshpool attachattachmode even when the attached shell exits non-zeroRoot cause
shpool attachcurrently returns success when a session is busy, so callers cannot distinguish a successful attach from thealready has a terminal attachedpath. The existing shell-status behavior also means the eventual shell exit code answers a different question from whether attach itself succeeded.The new mode keeps the existing behavior compatible while giving scripts and wrappers an explicit attach-status contract.
Closes #153.
Validation
cargo +1.85.0 check --workspacecargo +1.85.0 test --all-features --test attach(55 passed, 9 platform-specific tests ignored)cargo +nightly fmt -- --checkcargo +nightly clippy --all-targets --all-features -- -D warnings -A mismatched-lifetime-syntaxes(allows the existing warning intest_hooks.rs)AI usage
AI assistance was used to inspect the codebase, draft the implementation and tests, and prepare this PR description. I reviewed the resulting diff and ran the validation commands above locally.