docs: add mtp to accepted training.strategy values - #830
Open
imitater-dou wants to merge 1 commit into
Open
Conversation
The recipe catalog lists the accepted `training.strategy` values as `eagle3`, `peagle`, `dflash`, `domino`, or `dspark`, but the builtin algorithm catalog also registers `mtp` (`specforge/algorithms/builtin.py`), and the checked-in recipe `examples/configs/online/disaggregated/managed-local/qwen3.5-4b-mtp-disaggregated-npu.yaml` already sets `strategy: "mtp"`. Add it to the documented list so the table matches the registry. Signed-off-by: ADou <ikun3.1415927@gmail.com>
imitater-dou
requested review from
FlamingoPg,
shuaills and
sleepcoo
as code owners
September 3, 2026 15:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
examples/configs/README.mddocuments the acceptedtraining.strategyvalues as
eagle3,peagle,dflash,domino, ordspark. The builtinalgorithm catalog registers six algorithms, including
mtp:mtpis not an experimental name either — the checked-in recipeexamples/configs/online/disaggregated/managed-local/qwen3.5-4b-mtp-disaggregated-npu.yamlalready sets
strategy: "mtp", anddocs/basic_usage/training.mddocumentsMTP in its strategy/attention-backend notes and its
scripts/merge_mtp_to_base.pydeployment flow. Readers who pick theirstrategy from the recipe-catalog table therefore see one fewer strategy than
the code accepts.
Verified against
main@6c6b75e:An unknown value is rejected with the same list, confirming these are the
accepted values:
Modifications
examples/configs/README.md: addmtpto thetraining.strategyrow'saccepted values.
Docs only; one line. No strategy-specific row is added to the
"Strategy-specific fields" table because
mtpdefines no extratraining.*fields.
Related Issues
None.
Accuracy Test
Not applicable — documentation only, no model-side code touched.
Benchmark & Profiling
Not applicable — documentation only, no runtime code touched.
Checklist