[Draft] Add nodejs 26 - #547
Open
tjuhaszrh wants to merge 3 commits into
Open
Conversation
This commit adds comprehensive distgen support for generating Dockerfiles from templates and fixes multiple critical configuration issues across all Node.js versions (20, 22, 24) and distributions (RHEL, CentOS Stream, Fedora). Template fixes (src/): - Dockerfile: Fix usage label to handle undefined full_image_name - Dockerfile.minimal: Remove duplicate NPM_RUN=start environment variable - Dockerfile.minimal.fedora: Add com.redhat.license_terms label - Dockerfile.minimal.fedora: Add post_install support - Dockerfile.minimal.fedora: Add conditional rpm-file-permissions Configuration fixes (specs/multispec.yml): - fedora43: Add missing full_image_name, s2i_minimal_base, fedora_minimal_base - v20: Add libatomic_ops to build_deps for RHEL8/9/c9s (required for builds) - v20-minimal: Add nss_wrapper-libs to minimal_pkgs for non-Fedora - v22: Add libatomic_ops to build_deps for RHEL9/c9s - v22-minimal: Add libatomic_ops to build_deps for RHEL8/9/c9s - v22-minimal: Add nss_wrapper-libs to minimal_pkgs for RHEL10/c10s - v24: Add libatomic_ops to build_deps for RHEL9/c9s - v24-minimal: Add libatomic_ops to build_deps for RHEL8/9/c9s - v24-minimal: Add nss_wrapper-libs to minimal_pkgs for RHEL10/c10s/fedora - c9s: Add post_install for tzdata updates All generated Dockerfiles updated to reflect these fixes. Verified builds: 22/Dockerfile.fedora, 22-minimal/Dockerfile.fedora (successful)
Adds Node.js 26 support across all supported distributions: - RHEL 8/9/10 - CentOS Stream 9/10 - Fedora 43 Both standard and minimal variants included. Configuration inherits all distgen fixes from base commit.
|
Important Review skippedToo many files! This PR contains 144 files, which is 44 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (144)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
[test][test-pytest] |
Testing Farm results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.