fix: complete the distros foo.spec example#49
Closed
henryiii wants to merge 4 commits into
Closed
Conversation
The example spec was a hollow stub with only a preamble and an empty %files section, while the chapter and slides walk through a full spec. Flesh it out to match the walked-through spec, including the %pyproject_buildrequires -x test fix from PR #46 so pytest is present in the buildroot for %check. Assisted-by: ClaudeCode:claude-opus-4-8
The example spec was a hollow stub with only a preamble and an empty %files section, while the chapter and slides walk through a full spec. Flesh it out to match the walked-through spec, including the %pyproject_buildrequires -x test fix from PR #46 so pytest is present in the buildroot for %check. Assisted-by: ClaudeCode:claude-opus-4-8
Now that #46 is merged, the chapter can include the example spec directly instead of carrying an inline copy, so the two cannot drift again. The Marp deck keeps its inline copy (no include mechanism). Assisted-by: ClaudeCode:claude-opus-4-8
Collaborator
|
The difference is intentional. That example is a no-op version that they can start building on top of it. Would probably add this one alongside |
Contributor
Author
|
Ah, okay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
examples/5_04_distros/foo.specwas a hollow stub (just a preamble and an empty%files) while the chapter and slides walk through a full spec, so it had drifted.foo.specinto the complete spec taught by the chapter/slides:%prep,%generate_buildrequires,%build,%install,%check,%files -f %{pyproject_files}, plus the requiredBuildRequires: python3-devel.%pyproject_buildrequires -x testso pytest is available for%check.content/other-tools/04_distros.mdliteralincludesfoo.specinstead of carrying an inline copy, so the two cannot drift again. The Marp deck keeps its (identical) inline copy since Marp has no include mechanism.