docs: fix factual and consistency issues#48
Merged
Conversation
Corrections surfaced by a multi-agent review: - pybind11: C++17 (not C++11), modern PYBIND11_OVERRIDE_* macros, bump FetchContent GIT_TAG to v3.0.4, and note nanobind is not header-only. - scikit-build-core overrides: fix implementation-version and platform-machine/platform-node source descriptions. - Stable ABI: use the normal cp314-cp314 tag for the standard-wheel example. - uv: uvx environments are cached and reused (not recreated weekly); use @latest or --refresh to update. Fix VIRTUAL_ENV variable name. - Sync rust pixi.toml snippet platforms with the example file. - Lazy imports: Python 3.15 is in beta; clarify lazy is forbidden in try blocks (PEP 810). - Rename duplicate MyST label pkg-build to compiled-pkg-build. - Fix code-block languages, a literal directive fence, list indentation, and an issue vs pull link. Assisted-by: ClaudeCode:claude-opus-4-8
henryiii
commented
Jul 13, 2026
This was referenced Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Corrections surfaced by a multi-agent review of the book and slides.
CMAKE_CXX_STANDARD 17), switch deprecatedPYBIND11_OVERLOAD_*macros toPYBIND11_OVERRIDE_*(chapter, slide, and the literalincluded example), bump the FetchContentGIT_TAGtov3.0.4, and note nanobind is not header-only.implementation-versionmaps tosys.implementation.version, andplatform-machine/platform-nodecome fromplatform.machine()/platform.node().cp314-cp314tag instead of the free-threadedcp314-cp314t.uvxenvironments are content-addressed and cached/reused (not recreated weekly); updated the guidance touvx pkg@latest/--refresh. FixedVIRTUAL_ENVvariable name.pixi.tomlsnippet platforms with the example file.lazy importinsidetryblocks and that the error-moves-to-first-use trap only arises once the guard is removed.pkg-buildMyST label (removing a build warning), fixed two mislabeled code-block languages, converted a literal option fence to a{code}directive, re-indented a fragmented list, and pointed#1317at the issue rather than a pull request.Verified
prek -aclean andbun run buildpassing with the duplicate-identifier warning gone.