Add S3 integration tests - #2067
Open
PeterDowdy wants to merge 2 commits into
Open
Conversation
… running these tests against minio and added a ci step Signed-off-by: Peter Dowdy <peter.dowdy@gmail.com> Assisted-by: Claude:claude-sonnet-5
Signed-off-by: Peter Dowdy <peter.dowdy@gmail.com> Assisted-by: Claude:claude-sonnet-5
Member
|
Thank you for this. I won't have time to look at it for the next few weeks but I will get round to it. |
Contributor
Author
No rush! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds S3 integration tests through minIO as a mocked S3 provider. It covers most of the happy and sad paths in the project, with moderate rigour. It doesn't check transient errors (since the library just dies on them anyways), TLS verification (since that seems like it's drifting out of testing S3), or very large synthetic files (to keep runtime short).
The minIO test depends on an env var so developers without minIO can safely bypass it.
This effort surfaced a few fairly small gaps in S3 file-handling that could be filled:
Assisted-by: Claude:claude-sonnet-5