feat: add package trust link deny command - #1279
Open
btrn11 wants to merge 2 commits into
Open
Conversation
Allow verified PBO admins to accept a pending trust link by request ID or authoring org through the published packaging API.
Let a Verified PBO decline a pending Public Secure trust request by request ID or authoring org ID.
4 tasks
jshackell-sfdc
left a comment
jshackell-sfdc
left a comment
Contributor
There was a problem hiding this comment.
Please see my questions.
| @@ -0,0 +1,29 @@ | |||
| # summary | |||
|
|
|||
| Approve a Public Secure trust link request. | |||
Contributor
There was a problem hiding this comment.
Do customers know what a Public Secure trust link request is? Add a brief blurb about it if not.
|
|
||
| # description | ||
|
|
||
| Run this command against a verified packaging org (PBO) to accept a pending VerifiedDev trust request from an authoring org. Identify the request with either --request or --authoring-org. |
Contributor
There was a problem hiding this comment.
Is a pending VerifiedDev trust request the same thing as a Public Secure trust link request?
If so, can you keep to one term? And explain what it is all is?
| @@ -0,0 +1,31 @@ | |||
| # summary | |||
|
|
|||
| Deny a Public Secure trust link request. | |||
Contributor
There was a problem hiding this comment.
Same comments as the approve command above.
Contributor
There was a problem hiding this comment.
I noticed you have a number of PRs around these same commands. So same comments for those PRs too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sf package trust link denyfor verified PBO admins--request <2vt...>or--authoring-org <00D...>and delegate toPackageTrustLink.denyStatus = Declined); JSON schema and command snapshot coverageLibrary: forcedotcom/packaging#922. Plugin CI needs that library on npm (next
5.0.9-spi.*after packaging#921 /5.0.9-spi.4) before the pin can be bumped the way approve used5.0.9-spi.4.Also stacks on plugin-packaging#1277 (approve command). Extra approve commits drop out once that PR merges.
Test plan
yarn mocha test/commands/package/packageTrustLinkDeny.test.ts@salesforce/packagingto the published SPI build that includesdeny