add IBM f128 type - #162156
Draft
folkertdev wants to merge 8 commits into
Draft
Conversation
rustbot
added
A-attributes
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tracking issue: #161787
aka
__ibm128,ppc_fp128, etc. Making this change without having settled on a final name is a bit awkward but hopefully we can get some rounds of review in anyway.This should only merge after #160859 (so that I can deal with the merge conflicts).
I did hit that while
rustc_apfloathas aDoubleDoubletype, it does not implementFloatConvert(not even for conversions to itself), and itsFloatimplementation usesFallback, i.e. loses precision. LLVM has FIXMEs for this but clearly nobody has looked at this so far. So, a bunch of stuff for const eval / miri is stubbed out for now.