fix `is_homogeneous_aggregate`: use unit size, not total size by folkertdev · Pull Request #161394 · rust-lang/rust

folkertdev · 2026-08-20T11:17:40Z

The vector case of the three (arm, aarch64, powerpc64) is_homogeneous_aggregate implementations looked at the total type size, instead of the unit size.

blocked on #161070 merging

r? davidtwco

folkertdev · 2026-08-20T11:20:36Z

            // do not get homogeneous aggregate treatment.
            RegKind::Float => cx.target_spec().rustc_abi != Some(RustcAbi::Softfloat),
-            RegKind::Vector { .. } => size.bits() == 64 || size.bits() == 128,
+            RegKind::Vector { .. } => unit.size.bits() == 64 || unit.size.bits() == 128,


https://github.com/llvm/llvm-project/blob/a6f35d1c87513614baaa2f626257e8d4b8320fef/clang/lib/CodeGen/Targets/AArch64.cpp#L676-L700

View changes since the review

folkertdev · 2026-08-20T11:21:08Z

-            RegKind::Vector { .. } => size.bits() == 64 || size.bits() == 128,
+            RegKind::Vector { .. } => unit.size.bits() == 64 || unit.size.bits() == 128,


https://github.com/llvm/llvm-project/blob/a6f35d1c87513614baaa2f626257e8d4b8320fef/clang/lib/CodeGen/Targets/ARM.cpp#L756-L770

View changes since the review

folkertdev · 2026-08-20T11:21:29Z

            RegKind::Integer => false,
            RegKind::Float => true,
-            RegKind::Vector { .. } => arg.layout.size.bits() == 128,
+            RegKind::Vector { .. } => unit.size.bits() == 128,


https://github.com/llvm/llvm-project/blob/a6f35d1c87513614baaa2f626257e8d4b8320fef/clang/lib/CodeGen/Targets/PPC.cpp#L818-L838

View changes since the review

nazar-pc · 2026-08-20T11:27:47Z

Worth adding u64 aggregates here too?

View changes since the review

folkertdev · 2026-08-20T17:03:02Z

+    // When the fields are not 64 or 128 bits in size, they do not qualify as a homogeneous
+    // aggregate, and passed as type-erased sequences of integers.

-    // CHECK: define [4 x <4 x i8>] @quad_int8x4_t([4 x <4 x i8>] {{.*}} %0)
+    // CHECK: define [2 x i64] @quad_int8x4_t([2 x i64] {{.*}} %0)


these previously passed the aggregate check, but that was wrong

View changes since the review

folkertdev · 2026-08-20T17:03:31Z

-    // Other configurations are not passed by-value but indirectly.
+    // Other configurations passed directly when they qualify as a homogeneous aggregate.

-    // CHECK: define void @pair_int128x1_t
+    // CHECK: define [2 x <1 x i128>] @pair_int128x1_t([2 x <1 x i128>]


these are now recognized as homogeneous aggregates

View changes since the review

davidtwco · 2026-09-04T13:21:43Z

@bors r+ rollup

rust-bors · 2026-09-04T13:21:46Z

📌 Commit 8a59847 has been approved by davidtwco

It is now in the queue for this repository.

…unit, r=davidtwco fix `is_homogeneous_aggregate`: use unit size, not total size fixes rust-lang#161382 The vector case of the three (arm, aarch64, powerpc64) `is_homogeneous_aggregate` implementations looked at the total type size, instead of the unit size. blocked on rust-lang#161070 merging r? davidtwco

GuillaumeGomez · 2026-09-04T14:09:57Z

Failed in #162297. Might be a conflict between two PRs.

@bors r-

rust-bors · 2026-09-04T14:10:05Z

This pull request was unapproved.

View changes since this unapproval

rustbot · 2026-09-04T14:15:28Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

folkertdev · 2026-09-04T19:11:27Z

Yup simple merge conflict

@bors r=davidtwco

rust-bors · 2026-09-04T19:11:30Z

📌 Commit a305a9c has been approved by davidtwco

It is now in the queue for this repository.

…uwer Rollup of 25 pull requests Successful merges: - #162072 (Add new Tier-3 target: `powerpc64-sony-ps3`) - #162179 (type system const items via direct rhs) - #162255 (let people change rustc-dev-guide in-tree) - #162262 (Avoid manually instantiating some binders in error reporting with `-Znext-solver`) - #162277 (Introduce `rustc_middle::middel::resolve`) - #162285 (box: fixup map/try_map deallocate calls) - #162286 (string: don't unwind prematurely) - #162289 (alloc: a bunch of safety comments) - #162290 (abby test DSL: AliasTyOutlivesViaEnv) - #162292 (Update `askama` version to `0.16.1`) - #160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`) - #160906 (Suggest usize instead of placeholder type for array length constants) - #160936 (traits: Represent live alias arguments as bitsets) - #161394 (fix `is_homogeneous_aggregate`: use unit size, not total size ) - #161400 (Improve diagnostics for references to closures) - #161656 (Suggest mutable references for FnMut closure arguments) - #161711 (Add more splat fn type tests) - #161786 (Make `tcx.def_id_partial_cmp` public) - #161953 (sanitizers: Implicitly disable mutually exclusive sanitizers) - #162155 (add suggestion for `rustc_allowed_through_unstable_modules` attribute) - #162212 (Implement `Rng` for `Box`) - #162246 (Fix incorrect meta span) - #162266 (std: fix typo) - #162291 (Add regression test from 1.98.1) - #162303 (Fix a minor spelling error in `library/std/src/sys/fs/unix.rs`)

…unit, r=davidtwco fix `is_homogeneous_aggregate`: use unit size, not total size fixes rust-lang#161382 The vector case of the three (arm, aarch64, powerpc64) `is_homogeneous_aggregate` implementations looked at the total type size, instead of the unit size. blocked on rust-lang#161070 merging r? davidtwco

…uwer Rollup of 25 pull requests Successful merges: - #162072 (Add new Tier-3 target: `powerpc64-sony-ps3`) - #162179 (type system const items via direct rhs) - #162255 (let people change rustc-dev-guide in-tree) - #162262 (Avoid manually instantiating some binders in error reporting with `-Znext-solver`) - #162277 (Introduce `rustc_middle::middel::resolve`) - #162285 (box: fixup map/try_map deallocate calls) - #162286 (string: don't unwind prematurely) - #162289 (alloc: a bunch of safety comments) - #162290 (abby test DSL: AliasTyOutlivesViaEnv) - #162292 (Update `askama` version to `0.16.1`) - #160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`) - #160906 (Suggest usize instead of placeholder type for array length constants) - #160936 (traits: Represent live alias arguments as bitsets) - #161394 (fix `is_homogeneous_aggregate`: use unit size, not total size ) - #161400 (Improve diagnostics for references to closures) - #161656 (Suggest mutable references for FnMut closure arguments) - #161711 (Add more splat fn type tests) - #161786 (Make `tcx.def_id_partial_cmp` public) - #161953 (sanitizers: Implicitly disable mutually exclusive sanitizers) - #162155 (add suggestion for `rustc_allowed_through_unstable_modules` attribute) - #162212 (Implement `Rng` for `Box`) - #162246 (Fix incorrect meta span) - #162266 (std: fix typo) - #162291 (Add regression test from 1.98.1) - #162303 (Fix a minor spelling error in `library/std/src/sys/fs/unix.rs`)

Rollup merge of #161394 - folkertdev:arm-aarch64-hva-vector-unit, r=davidtwco fix `is_homogeneous_aggregate`: use unit size, not total size fixes #161382 The vector case of the three (arm, aarch64, powerpc64) `is_homogeneous_aggregate` implementations looked at the total type size, instead of the unit size. blocked on #161070 merging r? davidtwco

rust-timer · 2026-09-06T08:55:09Z

Note

This PR was benchmarked as part of triage of its containing rollup: triage URL.

Finished benchmarking commit (334273c): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.4%, secondary 2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	7.5%	[7.5%, 7.5%]	1
Regressions ❌ (secondary)	2.5%	[2.5%, 2.5%]	1
Improvements ✅ (primary)	-7.4%	[-11.7%, -3.0%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.4%	[-11.7%, 7.5%]	3

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: missing data
Artifact size: 403.29 MiB -> 403.37 MiB (0.02%)

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 20, 2026

rustbot assigned davidtwco Aug 20, 2026

folkertdev changed the title ~~Arm aarch64 hva vector unit~~ fix is_homogeneous_aggregate: use unit size, not total size Aug 20, 2026

folkertdev commented Aug 20, 2026

View reviewed changes

nazar-pc reviewed Aug 20, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

folkertdev force-pushed the arm-aarch64-hva-vector-unit branch from a91d2f2 to fd3fd89 Compare August 20, 2026 15:31

folkertdev commented Aug 20, 2026

View reviewed changes

folkertdev force-pushed the arm-aarch64-hva-vector-unit branch from fd3fd89 to 8a59847 Compare August 20, 2026 18:14

rustbot added the A-test-infra-minicore Area: `minicore` test auxiliary and `//@ add-core-stubs` label Aug 20, 2026

This comment has been minimized.

Sign in to view

folkertdev mentioned this pull request Aug 23, 2026

C interop: Complex<T> rust-lang/goals#761

Open

davidtwco approved these changes Sep 4, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2026

GuillaumeGomez mentioned this pull request Sep 4, 2026

Rollup of 25 pull requests #162297

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 4, 2026

fix is_homogeneous_aggregate: use unit size, not total size

a305a9c

folkertdev force-pushed the arm-aarch64-hva-vector-unit branch from 8a59847 to a305a9c Compare September 4, 2026 14:15

rust-bors Bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 4, 2026

rust-bors Bot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 4, 2026

JonathanBrouwer mentioned this pull request Sep 4, 2026

Rollup of 25 pull requests #162310

Merged

Zalathar mentioned this pull request Sep 5, 2026

Rollup of 20 pull requests #162317

Closed

rust-bors Bot merged commit e82904d into rust-lang:main Sep 5, 2026
13 checks passed

rustbot added this to the 1.100.0 milestone Sep 5, 2026

		RegKind::Vector { .. } => size.bits() == 64 \|\| size.bits() == 128,
		RegKind::Vector { .. } => unit.size.bits() == 64 \|\| unit.size.bits() == 128,

Uh oh!

Uh oh!

Conversation

folkertdev commented Aug 20, 2026

Uh oh!

folkertdev Aug 20, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

folkertdev Aug 20, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

folkertdev Aug 20, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nazar-pc Aug 20, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

folkertdev Aug 20, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

folkertdev Aug 20, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

davidtwco commented Sep 4, 2026

Uh oh!

rust-bors Bot commented Sep 4, 2026

Uh oh!

GuillaumeGomez commented Sep 4, 2026

Uh oh!

rust-bors Bot commented Sep 4, 2026

Uh oh!

rustbot commented Sep 4, 2026

Uh oh!

folkertdev commented Sep 4, 2026

Uh oh!

rust-bors Bot commented Sep 4, 2026

Uh oh!

Uh oh!

rust-timer commented Sep 6, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

folkertdev Aug 20, 2026 •

edited by rustbot

Loading

folkertdev Aug 20, 2026 •

edited by rustbot

Loading

folkertdev Aug 20, 2026 •

edited by rustbot

Loading

nazar-pc Aug 20, 2026 •

edited by rustbot

Loading

folkertdev Aug 20, 2026 •

edited by rustbot

Loading

folkertdev Aug 20, 2026 •

edited by rustbot

Loading