Make the comments & communications feed legible to non-technical users - #2556
Merged
Merged
Conversation
Facilitators couldn't tell the add-a-note area apart from the filter + results below it — both sat in the same cream box. Split them into two titled zones with a divider, and give the filter a cool gray toolbar so it reads distinct from the warm cream Add panel. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
maebeale
marked this pull request as ready for review
September 21, 2026 02:41
Facilitators missed the jump-to-a-person control and misread the top box as another search field. Make the switcher a wide, people-tinted control captioned 'Open a person's feed…', and retitle the top box 'Log a comment or communication' with a 'Who's it about?' picker so it reads as creating an entry, not navigating. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
maebeale
changed the title
Facilitators were confused by the top toggle relabelling to 'Cancel'. The
Add trigger now hides once its composer opens; the composer carries the
app's action-green submit with a Cancel button beside it. Also retitle the
Add box 'Add a comment or communication', ask 'Who's the new log about?',
and style the results header like the section headers ('Feed: Comments &
communications').
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Drop the panel-toggle JS addition; aria-expanded (which the controller already toggles) plus an aria-expanded:hidden utility collapses the trigger when its panel opens. The attribute selector outranks inline-flex, which a plain .hidden class couldn't. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Drop internal jargon: picker asks 'Who is this about?', the browse header becomes 'Find a comment or communication' (parallel to the Add/Feed headers, no more double 'Feed'), and remove the confusing follow-up/ responded-flag explainer sentence from the filter. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The 9-field filter overwhelmed non-technical users, so show just Keyword + Show and tuck the other 7 behind a 'More filters' toggle (reuses panel-toggle, no new JS); the panel auto-opens when any advanced filter is already applied so an active filter is never hidden. Reword the view switcher 'Open a person's feed…' to the plainer 'See one person…'. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
maebeale
changed the title
Use the standard text-link + rotating chevron (expandable-card) for 'More filters' instead of a bordered button, and move Attached to into the always-visible row. Rename the browse header to 'Search comments & communications' and drop the last 'Feed' jargon (results header now 'Results'); switcher reads 'See one person…'. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Match the Add zone to the Search/Results zones — section header above the cream card, not inside it. Add the 'Clearer comments & communications feed' entry to config/features.yml. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
On a person's feed the New comment / New communication buttons now sit in the page header beside the name (index_page gains an optional content_data so one panel-toggle scope spans the header actions and the body where the composers open). Drops the big cream Add card there. The everyone feed keeps its pick-a-person card since there's no target person yet. Extract shared add_buttons + composer_panels partials. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- Style New comment / New communication as the app's admin primary_outline buttons and center them on the name row (index_page header_align local). - Drop the everyone feed's add card entirely — add from a person's feed after filtering to them. - Move the person picker out of the title into the filter row (labelled Person, 'Filter to one person'), shrink the Keyword box, keep 'View everyone' by the name. - Results header reads 'N comments & communications' instead of 'N shown'. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Show whose feed you're on in the Person field instead of a blank 'Filter to one person' placeholder. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
maebeale
added a commit
that referenced
this pull request
Sep 21, 2026
Rebase onto #2556 moved the follow-up filters behind a More filters toggle; include the flagged param in the advanced-active check so an active Flagged filter is never hidden on load. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
maebeale
added a commit
that referenced
this pull request
Sep 21, 2026
After #2556 the results header appends 'comments & communications' to the count; when grouping, the count is a subject count, so drop the suffix. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 3 Read 📖 markup + copy on the comments & communications feed; reuses existing Stimulus, no new JS
Facilitators (many non-technical) couldn't tell the feed's controls apart or understand its labels. This restructures the page into clear zones with plain language and lighter defaults.
Header
aria-expanded:hidden).Search zone
bg-gray-100filter card.expandable-cardpattern), auto-opening when an advanced filter is applied.Plumbing (no new JS)
shared/_index_pagegains optionalcontent_data(apanel-togglescope spanning the header actions + body) andheader_align.add_buttons+composer_panelspartials; shared composers take an optionalcancel_name:.Also
config/features.yml).Screenshots are in the Conductor thread.
🤖 Generated with Claude Code