Walkthrough of dogstack-example - #5
Open
michael-smith-nz wants to merge 9 commits into
Open
Conversation
ahdinosaur
reviewed
Dec 4, 2017
|
|
||
| #### root.js | ||
|
|
||
| To ask Mikey - what's the purpose of styleNode in dogstack (in root.js)? I see where we use appNode, but don't see styleNode being used at all? |
Member
There was a problem hiding this comment.
since root-systems/dogstack@0197d3e, styleNode is no longer used
ahdinosaur
reviewed
Dec 4, 2017
|
|
||
| > An Epic is a function which takes a stream of actions and returns a stream of actions. Actions in, actions out. | ||
|
|
||
| Need this looked at, still confusing to me after looking into `dogstack-agents` |
Member
There was a problem hiding this comment.
epics (via redux-observable) are an abstraction in the same space as redux-thunk or redux-saga or redux-loop, it's meant to address the functionality missing in redux for async actions. epics allow us to observe the stream of actions, so we can do async operations like fetching or saving data, by listening for when the initial action is dispatched, then dispatching a series of sync (update) actions based on the progress of the async operation.
michael-smith-nz
requested review from
ahdinosaur,
iainkirkpatrick and
sarah-arrrgh
December 8, 2017 13:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sections needed for walkthrough of app
react-felarecompose(ideally later)ramdawith usingisNilas an examplegettersandreselect