[df] Handle containers in RHist filling - #22899
Draft
hahnjo wants to merge 2 commits into
Draft
Conversation
As for the existing Histo actions, the sizes of all containers must match while scalars are broadcasted. As an extension, this works recursively, so nested vectors are handled one level at a time.
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 613e0bd. ♻️ This comment has been updated with latest results. |
Contributor
|
Hi! Thanks, this feature is what I was looking for when trying to switch my code from Histo to Hist. Giovanni |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As for the existing Histo actions, the sizes of all containers must match while scalars are broadcasted. As an extension, this works recursively, so nested vectors are handled one level at a time.