fix: return api key delete response#231
Conversation
|
@cubic-dev-ai review this PR |
@mayankbohradev I can’t start this review because this PR was opened by an external contributor in a public repository. Ask an installation member or outside collaborator to comment |
Codecov ReportCaution This repository is currently using the Sentry GitHub App to receive Codecov PR comments. This integration will be deprecated on July 8, 2026. Please install the Codecov GitHub App to continue receiving coverage reports on your pull requests. Additional details and impacted files@@ Coverage Diff @@
## main #231 +/- ##
===========================================
+ Coverage 82.66% 95.64% +12.97%
===========================================
Files 4 58 +54
Lines 75 3100 +3025
===========================================
+ Hits 62 2965 +2903
- Misses 13 135 +122 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
thanks for the contribution @mayankbohradev |
What
Why
Testing
Summary by cubic
Return the documented API key delete response instead of None, so callers can confirm deletion. Adds
ApiKeys.DeleteApiKeyResponseand updatesApiKeys.remove/remove_asyncinresend.ApiKeys.removeandApiKeys.remove_asyncnow returnApiKeys.DeleteApiKeyResponsewithobject,id, anddeleted.perform_with_contentto parse the delete response; tests updated to assert returned fields.Written for commit 5cdc608. Summary will update on new commits.