Skip to content

Complete frontend_path validation for Win32-trimmed and empty segments - #7105

Merged
masenf merged 1 commit into
mainfrom
codex/prerelease-014-path-validation
Sep 11, 2026
Merged

Complete frontend_path validation for Win32-trimmed and empty segments#7105
masenf merged 1 commit into
mainfrom
codex/prerelease-014-path-validation

Conversation

@masenf

@masenf masenf commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

The frontend-path guard added in #7044 still accepts directory names that Win32 trims and repeated separators. Reject trailing dots/spaces and empty internal segments before building or relocating the frontend, while retaining root paths, one optional trailing slash, interior spaces, and ordinary dotted names.

Addresses prerelease finding 014.

Validation: seven new unsafe-path cases failed before the fix; all 142 config tests pass afterward. Ruff lint and formatting pass. Reviewed boundary cases for empty/root prefixes and legitimate names.

Review in cubic

@masenf
masenf requested a review from a team as a code owner September 11, 2026 05:53

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the validation consistently rejects the targeted unsafe forms without disrupting the explicitly retained path forms.

Summary

  • Rejects path segments ending in dots or spaces that Win32 trims.
  • Rejects empty internal segments introduced by repeated separators.
  • Preserves empty and root paths, one optional boundary slash, interior spaces, and ordinary dotted names.
  • Adds regression coverage and a downstream-facing bugfix fragment.

Reviews (1) · Last reviewed commit: "fix(config): reject trimmed and empty fr..."

@codspeed-hq

codspeed-hq Bot commented Sep 11, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 40 untouched benchmarks
⏩ 8 skipped benchmarks1


Comparing codex/prerelease-014-path-validation (4404c19) with main (074a818)

Open in CodSpeed

Footnotes

  1. 8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@masenf masenf added this to the 0.9.11 milestone Sep 11, 2026
@masenf
masenf merged commit 17e9ed3 into main Sep 11, 2026
114 checks passed
@masenf
masenf deleted the codex/prerelease-014-path-validation branch September 11, 2026 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant