Complete frontend_path validation for Win32-trimmed and empty segments - #7105
Merged
Conversation
Contributor
|
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The frontend-path guard added in #7044 still accepts directory names that Win32 trims and repeated separators. Reject trailing dots/spaces and empty internal segments before building or relocating the frontend, while retaining root paths, one optional trailing slash, interior spaces, and ordinary dotted names.
Addresses prerelease finding 014.
Validation: seven new unsafe-path cases failed before the fix; all 142 config tests pass afterward. Ruff lint and formatting pass. Reviewed boundary cases for empty/root prefixes and legitimate names.