Skip to content

Chore: Update e2e tests#1204

Open
varshab1210 wants to merge 1 commit into
redhat-developer:masterfrom
varshab1210:test-updates
Open

Chore: Update e2e tests#1204
varshab1210 wants to merge 1 commit into
redhat-developer:masterfrom
varshab1210:test-updates

Conversation

@varshab1210

Copy link
Copy Markdown
Member

What type of PR is this?

/kind failing-test

What does this PR do / why we need it:

Fixes a few test failures against RC

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

Signed-off-by: Varsha B <vab@redhat.com>
@openshift-ci openshift-ci Bot added the kind/failing-test Categorizes issue or PR as related to a frequently failing test. label Jul 6, 2026
@openshift-ci openshift-ci Bot requested review from AdamSaleh and jannfis July 6, 2026 08:18
@openshift-ci

openshift-ci Bot commented Jul 6, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign varshab1210 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@varshab1210 varshab1210 changed the title update e2e tests Chore: Update e2e tests Jul 6, 2026
@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: fbe72d3e-e86b-44ca-85ca-fee1ca9aacdf

📥 Commits

Reviewing files that changed from the base of the PR and between 543c4f5 and 990c190.

📒 Files selected for processing (3)
  • test/openshift/e2e/ginkgo/parallel/1-031_validate_toolchain_test.go
  • test/openshift/e2e/ginkgo/sequential/1-051_validate_argocd_agent_principal_test.go
  • test/openshift/e2e/ginkgo/sequential/1-052_validate_argocd_agent_agent_test.go
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • argoproj-labs/argocd-operator (manual)

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Updated validation to match the current supported versions of key components.
    • Improved image checks so they work correctly across different run environments and image registries.

Walkthrough

This PR updates e2e test expectations: the toolchain validation test now expects Argo CD server version v3.4.4 and (for non-prow CI) Redis version 7.2.11. Two argocd agent e2e tests now conditionally assert container image values based on runtime environment (CI/local/non-OLM vs. registry image prefix).

Changes

E2E Test Assertion Updates

Layer / File(s) Summary
Toolchain version expectations
test/openshift/e2e/ginkgo/parallel/1-031_validate_toolchain_test.go
Updated expected Argo CD server version from v3.4.2 to v3.4.4, and non-prow expected Redis version from 8.2.3 to 7.2.11.
Argocd agent image assertions
test/openshift/e2e/ginkgo/sequential/1-051_validate_argocd_agent_principal_test.go, test/openshift/e2e/ginkgo/sequential/1-052_validate_argocd_agent_agent_test.go
Replaced single unconditional default-image equality checks with environment-conditional assertions: CI/local/non-OLM environments expect the default agent image name, others expect an image with the registry.redhat.io/openshift-gitops-1/argocd-agent-rhel9 prefix.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and matches the main change: updating e2e tests.
Description check ✅ Passed The description is related to the changeset and explains the failing-test fix against the RC.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 6, 2026

Copy link
Copy Markdown

@varshab1210: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.19-ci-index-gitops-operator-bundle 990c190 link true /test v4.19-ci-index-gitops-operator-bundle
ci/prow/v4.14-ci-index-gitops-operator-bundle 990c190 link true /test v4.14-ci-index-gitops-operator-bundle
ci/prow/v4.14-kuttl-parallel 990c190 link false /test v4.14-kuttl-parallel
ci/prow/v4.19-e2e 990c190 link true /test v4.19-e2e
ci/prow/v4.19-kuttl-sequential 990c190 link true /test v4.19-kuttl-sequential
ci/prow/v4.19-kuttl-parallel 990c190 link true /test v4.19-kuttl-parallel
ci/prow/v4.14-kuttl-sequential 990c190 link false /test v4.14-kuttl-sequential

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/failing-test Categorizes issue or PR as related to a frequently failing test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant