[TypeDeclaration] Add doc return type only for list and generic arrays in ReturnTypeFromStrictNewArrayRector - #8423
Merged
Conversation
…apes in ReturnTypeFromStrictNewArrayRector Claude-Session: https://claude.ai/code/session_01RiikaWD1ZzLrmdeG6CT3D5
…s, skip array shapes Claude-Session: https://claude.ai/code/session_01RiikaWD1ZzLrmdeG6CT3D5
TomasVotruba
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #8422.
The rule now adds a doc return type only for plain
list<...>and genericarray<...>/mixed[]types. Any array shape (array{...}) — single, nested, or a union of several — is skipped: it always keeps the: arraynative return type but drops the noisy, fragile shape docblock.Replaces the previous union-only skip with a single
hasArrayShape()check that walks the type tree viaTypeTraverser. Adds a reservation-style union fixture; updatesdeep_nested_array(nested shape) to no longer emit a shape docblock.