Remove AddOverrideAttributeToOverriddenMethodsRector from PHP 8.3 and polyfill sets - #8321
Merged
Merged
Conversation
…olyfill sets The rule adds #[Override] to every overridden method, which spams the codebase with attributes without bringing real value. It stays available for explicit opt-in registration. Also drops RelatedPolyfillInterface, as it is no longer part of the php-polyfills set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rule adds
#[Override]to every single overridden method. In practice that spams the codebase with attributes without bringing real value, so it should not run automatically as part ofwithPhpSets().class SomeChild extends SomeParent { - #[\Override] public function run() { } }Changes:
config/set/php83.phpconfig/set/php-polyfills.phpRelatedPolyfillInterfacefrom the rule, asRegisterRelatedPolyfillRectorRule(PHPStan) requires every polyfill-related rule to be registered in the polyfill setThe rule itself stays and can be registered explicitly: