Skip ReactNativeFeatureFlags in react-private-interface typegen - #58075
Draft
huntie wants to merge 1 commit into
Draft
Skip ReactNativeFeatureFlags in react-private-interface typegen#58075huntie wants to merge 1 commit into
huntie wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
cursor
Bot
force-pushed
the
cursor/fix-js-api-exports-resolution-db59
branch
from
August 22, 2026 19:07
9ee6f05 to
d243be5
Compare
huntie
changed the title
Minimum fix for react#57940: when react-private-interface gains a ReactNativeFeatureFlags export, do not translate src/private/featureflags/* into types_generated. - Skip react-native/react-private-interface in simpleResolve - Block feature-flags deps from react-private-interface.js.flow - Strip the feature-flags re-export from the generated .d.ts Co-authored-by: Alex Hunt <huntie@users.noreply.github.com>
huntie
changed the title
cursor
Bot
force-pushed
the
cursor/fix-js-api-exports-resolution-db59
branch
from
August 22, 2026 19:52
d243be5 to
2b77af6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
🚧 WIP and not ready for review yet — unsanitised Cursor draft
Summary
Minimum fix for #57940: when
react-private-interfaceexposesReactNativeFeatureFlags, do not translatesrc/private/featureflags/*intotypes_generated.react-native/react-private-interfaceinsimpleResolvesrc/private/featureflags/*deps fromreact-private-interface.js.flow.d.ts(resolution alone leaves a dangling export)Other
src/private/*re-exports (CustomEvent, etc.) are unchanged.Changelog: [Internal]
Test Plan
yarn build-typestypes_generated/**/featureflags/**