Skip to content

Use a more thorough cleanup of parallel workers #21981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilevkivskyi merged 1 commit into from
Sep 14, 2026
Merged

Use a more thorough cleanup of parallel workers #21981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion mypy/build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,10 +315,11 @@ def close(self) -> None:
if self.connected:
self.conn.close()
# Technically we don't need to wait, but otherwise we will get ResourceWarnings.
# Also, it is generally good to not leave some running worker processes behind.
try:
self.proc.wait(timeout=WORKER_SHUTDOWN_TIMEOUT)
except subprocess.TimeoutExpired:
pass
self.proc.terminate()
if os.path.isfile(self.status_file):
os.unlink(self.status_file)

Expand Down
2 changes: 1 addition & 1 deletion mypy/defaults.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
# with our generous timeouts, so we set them higher.
WORKER_START_INTERVAL: Final = 0.01 if sys.platform != "win32" else 0.03
WORKER_START_TIMEOUT: Final = 3 if sys.platform != "win32" else 10
WORKER_SHUTDOWN_TIMEOUT: Final = 1 if sys.platform != "win32" else 3
WORKER_SHUTDOWN_TIMEOUT: Final = 3 if sys.platform != "win32" else 10

WORKER_CONNECTION_TIMEOUT: Final = 10
WORKER_IDLE_TIMEOUT: Final = 600
Expand Down
Loading