Add basic support for PEP 798 - #21976
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
hauntsaninja
approved these changes
Sep 17, 2026
This comment has been minimized.
This comment has been minimized.
JukkaL
approved these changes
Sep 18, 2026
|
|
||
| def transform_generator_expr(builder: IRBuilder, o: GeneratorExpr) -> Value: | ||
| if isinstance(o.left_expr, StarExpr): | ||
| builder.error("PEP 798 is not supported yet", o.line) |
Collaborator
There was a problem hiding this comment.
Maybe also briefly mention that this is unsupported unpacking, since PEP numbers are not widely known? Maybe something like "Unsupported unpack (PEP 798 is not supported yet)".
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21489
Things are mostly straightforward. I also add support for old parser. Two non-trivial things:
ARG_STARactual kind, because there is a limitation inargmap.pythat it can't handle structural iterables. We have a bunch of issues open about this, and there were some attempts to fix it, but they stalled.builtins.objectif we use joins. I think it is fine, since this is a new syntax.