gh-156049: Add support for building with HWASAN - #156721
Open
StanFromIreland wants to merge 1 commit into
Open
Conversation
Co-authored-by: Florian Mayer <fmayer@google.com> Co-authored-by: Anna <araslanova.anna.a@gmail.com>
StanFromIreland
requested review from
AA-Turner,
corona10,
emmatyping,
erlend-aasland and
itamaro
as code owners
August 31, 2026 15:21
This was referenced Aug 31, 2026
Documentation build overview
|
fmayer
reviewed
Aug 31, 2026
| Enable HWAddressSanitizer memory error detector, ``hwasan`` (default is no). | ||
| Note that on x86-64 this uses `page aliasing | ||
| <https://clang.llvm.org/docs/HardwareAssistedAddressSanitizerDesign.html#supported-architectures>`_, | ||
| which only tags heap allocations and is unsafe for programs that ``fork()``, |
There was a problem hiding this comment.
I think implicitly this means "Do not use on x86-64", right?
Member
Author
There was a problem hiding this comment.
Pretty much, you could try using it if you're careful (as such it's an option).
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This supersedes GH-149166 and GH-156050, pulling in their changes and adding a
--with-hwaddress-sanitizerconfigure option as well as a few little miscellaneous changes for better support. Note that x86-64 has to use clang's page aliasingmode, which shares the heap across
fork(), so the test suite is only reliableon AArch64.
@AnnaAr321 and @fmayer I'd appreciate your reviews :-)