Stop depending on deprecated PyPI curio in tests#58
Closed
l46983284-cpu wants to merge 1 commit into
Closed
Conversation
Curio no longer publishes to PyPI, so the optional test dependency breaks installs and CI that try to pull it. Keep the runtime curio detection path, but cover it with a tiny module stub instead of installing the unmaintained package. Fixes python-trio#34 Signed-off-by: Alex Chen <l46983284@gmail.com>
Contributor
|
What's the point? |
Author
|
Curio on PyPI is unmaintained and breaks a clean test install ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stop installing the unmaintained PyPI
curiopackage in the test dependency group.Curio no longer publishes releases, so the test extra fails for environments that try to install it. Runtime detection for curio is unchanged; the test now exercises that path with a tiny
sys.modulesstub ofcurio.meta.curio_running.Fixes #34
Test plan
pip install --group test .without curio on PyPI install pathpytest -W error -ra -v --pyargs sniffio→ 4 passed (including new stubbed curio detection test)