Remove mode and size checks from C transpose methods - #9962
Open
radarhere wants to merge 1 commit into
Open
Conversation
akx
reviewed
Sep 4, 2026
akx
left a comment
Contributor
There was a problem hiding this comment.
I don't quite like this, because the loops just below assume that these preconditions hold.
Member
Author
|
I'm aware there's a difference of opinion here. We'll see what another reviewer thinks. |
Contributor
|
Also, per #9785 (comment) functions like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given that
_transposesetsimOutfromimInpropertiesPillow/src/_imaging.c
Line 2162 in 11de4b9
I don't think that subsequent functions need to check the mode and size.
#9785 is an alternative that goes in the opposite direction, checking the return values and cleaning up on failure.