Improve test stability - #9933
Open
akx wants to merge 2 commits into
Open
Conversation
…surement unreliable
The tall case still needs to allocate the row-pointer table `im->image`, which is still roughly 700 megabytes, which evidently can be slow
This was referenced Sep 2, 2026
Member
|
Regarding |
radarhere
reviewed
Sep 5, 2026
|
|
||
| @pytest.mark.skipif(sys.platform.startswith("win32"), reason="Requires Unix or macOS") | ||
| # Per https://stackoverflow.com/a/29007723/51685, due to JIT compilation, | ||
| # RSS utilization is known to grow so measuring it doesn't make that much sense. |
Member
There was a problem hiding this comment.
Suggested change
| # RSS utilization is known to grow so measuring it doesn't make that much sense. | |
| # RSS utilization is known to grow in PyPy. |
radarhere
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This proposes to fix the PyPy CI flakiness by skipping or adjusting the tests that are observed to be flaky.
test_empty_imageallocated 100,000,000 64-bit ints for row pointers, in the "tall" case, which, I guess, would take a while when there's memory pressure (again, see above; PyPy is known to be memory-hungrier).EDIT: Oh, the tall case also fails sometimes on vanilla macOS, e.g. here with "FAILED Tests/test_image.py::TestImage::test_empty_image[size0] - Failed: Timeout (>0.75s) from pytest-timeout." Making it allocate 10,000,000 ints instead of 100,000,000 should hopefully help, anyway.