Skip to content

Remove remaining :rtype:s from docstrings#9742

Merged
hugovk merged 1 commit into
python-pillow:mainfrom
akx:remove-rtypes
Jul 7, 2026
Merged

Remove remaining :rtype:s from docstrings#9742
hugovk merged 1 commit into
python-pillow:mainfrom
akx:remove-rtypes

Conversation

@akx

@akx akx commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

The type annotations for the functions describe the return type anyway, so no great reason I can think of to keep a redundant other copy around.

Noticed these in Chops while working on #9738 and figured I'd do a full sweep.

The type annotations for the functions describe the return type anyway.
@codspeed-hq

codspeed-hq Bot commented Jun 30, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 331 untouched benchmarks


Comparing akx:remove-rtypes (5ad6072) with main (6590b1b)

Open in CodSpeed

Comment thread src/PIL/ImageChops.py
@hugovk hugovk merged commit fc7cec1 into python-pillow:main Jul 7, 2026
54 checks passed
@akx

akx commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

How did the main commit fc7cec1 end up with @hugovk's authorship 😮

Or rather, I think squash merging PRs has retained the PR author's credits in the past? 🤔

@hugovk

hugovk commented Jul 9, 2026

Copy link
Copy Markdown
Member

It's not a squash merge commit, it's a regular merge commit.

fc7cec1 is my merge and it has two parents, one of which is your commit 5ad6072.

@akx

akx commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Ah! Sorry for the noise, my bad. I didn't check the parents correctly. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants