fix: detect ClassVar wrapped in ForwardRef on Python 3.14#1576
Open
muhamedfazalps wants to merge 1 commit into
Open
fix: detect ClassVar wrapped in ForwardRef on Python 3.14#1576muhamedfazalps wants to merge 1 commit into
muhamedfazalps wants to merge 1 commit into
Conversation
Python 3.14 uses annotationlib which returns annotations as ForwardRef objects instead of plain strings. str(ForwardRef(...)) produces a repr string like 'ForwardRef(...)' which does not match the ClassVar prefix checks. Fix by extracting __forward_arg__ from ForwardRef objects when available, which returns the raw annotation string. Fixes python-attrs#1575
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1575
Problem
In Python 3.14, annotations are returned as
ForwardRefobjects (via annotationlib) instead of plain strings.str(ForwardRef('ClassVar[str]'))produces the repr string"ForwardRef('ClassVar[str]', is_class=True)"which does not match the ClassVar prefix checks in_is_class_var.When
ClassVaris imported underTYPE_CHECKING, the annotation exists as a ForwardRef but goes undetected, causing attrs to treat ClassVar attributes as regular init parameters.Fix
Extract
__forward_arg__from ForwardRef objects when available, which returns the raw annotation string (e.g."ClassVar[str]"). Falls back tostr(annot)for older Python versions.If this helps, consider buying me a coffee! https://buymeacoffee.com/muhamedfazalps