fix: revoke Blob URLs created by p5.File - #9155
Open
slash-init wants to merge 6 commits into
Open
slash-init wants to merge 6 commits into
slash-init wants to merge 6 commits into
Conversation
|
Hi, I'd like to take this on. |
Contributor
Author
|
@rk-3001 i think you should read contributor guidelines first. |
Vaivaswat2244
suggested changes
Sep 16, 2026
Vaivaswat2244
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the pr @slash-init . Matches what we discussed on the issue, left a few comments.
slash-init
force-pushed
the
fix/file-blob-url-lifecycle
branch
from
September 16, 2026 12:05
de025d3 to
6cbdcea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #9134
Changes:
p5.File._load()on the owning p5 instance.p5.remove()is called.p5.File.revoke()for explicitly releasing a file's Blob URL.p5.File.revoke()idempotent and remove revoked URLs from the instance's tracking set.createFileInput()andElement.drop()so media files are tracked correctly.PR Checklist
npm run lintpasses