Fix/issue 8924

[solowiz398]

Resolves #8924

PROBLEM DESCRIPTION

The setter method of 'x' for a 1 dimension vector does not reflect any changes to its value.

Vector dimensions are stored in an array, the set method of x checks to see if the length of the array is greater than 1. The condition passes for a 2d vector but fails for a 1d vector

SOLUTION

Updated the setter method for 'x' to check to see if the length of the array is greater than 0. This condition passes for both a 1d vector and n amount of vector

HOW TO TEST

1. Verify the fix on this branch

npm test -- test/unit/math/p5.Vector.js

Ensure the following unit test passes:

'should show a value change for x with toString() for 1d Vector'

Changes:

• Fixed setter method for x in p5.Vector.js to allow setting values for 1d vector length > 0
• Added a unit test to verify value change for 'x'

Screenshots of the change:
Non visual code and unit test

PR Checklist

• npm run lint passes
• Inline reference is included / updated
• Unit tests are included / updated

[p5-bot]

Continuous Release

CDN link

• https://raw.esm.sh/pr/p5@fc03722/lib/p5.min.js

Published Packages

• https://pkg.pr.new/p5@fc03722

Commit hash: 4e2435f

Previous deployments

---

This is an automated message.

[ksen0]

One minor thing, otherwise thanks, happy to include this in the next patch!

[ksen0]

Thanks! Please update to match the style of other tests using expect to be (and removing the assert dep, I don't think it would be needed?)

[solowiz398]

Thanks @ksen0 I just made the changes. Let me know if there's anything else