GSOC-E2E-3: Add Mailpit-based email verification for signup e2e test - #4223
Open
Geethegreat wants to merge 4 commits into
Open
GSOC-E2E-3: Add Mailpit-based email verification for signup e2e test#4223Geethegreat wants to merge 4 commits into
Geethegreat wants to merge 4 commits into
Conversation
Closed
6 tasks
Geethegreat
force-pushed
the
mailpit-verification
branch
from
July 28, 2026 09:43
7bda9c9 to
cd29a0b
Compare
clairep94
reviewed
Jul 30, 2026
Comment on lines
+10
to
+22
| # temporary while new e2e environment is not yet created: | ||
| # only trigger on workflow_dispatch, maintainer comment, or if PR is from GSOC project mentor or mentee | ||
| if: > | ||
| github.event_name == 'workflow_dispatch' || | ||
| ( | ||
| github.event_name == 'pull_request' && | ||
| contains(fromJSON('["Geethegreat", "clairep94"]'), github.event.pull_request.user.login) | ||
| ) || | ||
| ( | ||
| github.event.issue.pull_request && | ||
| github.event.comment.body == '/e2e' && | ||
| contains(fromJSON('["OWNER", "MEMBER", "COLLABORATOR"]'), github.event.comment.author_association) | ||
| ) |
Collaborator
There was a problem hiding this comment.
revert this back to
environment: e2e-tests
clairep94
reviewed
Jul 30, 2026
Comment on lines
+36
to
+48
| - name: Resolve PR head ref | ||
| if: github.event_name == 'issue_comment' | ||
| id: pr | ||
| uses: actions/github-script@v7 | ||
| with: | ||
| script: | | ||
| const { data: pr } = await github.rest.pulls.get({ | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| pull_number: context.issue.number | ||
| }); | ||
| core.setOutput('sha', pr.head.sha); | ||
|
|
Collaborator
There was a problem hiding this comment.
we don't need this anymore
clairep94
reviewed
Jul 30, 2026
Comment on lines
+51
to
+52
| with: | ||
| ref: ${{ github.event_name == 'issue_comment' && steps.pr.outputs.sha || github.ref }} |
Collaborator
There was a problem hiding this comment.
we don't need this anymore
Per mentor review on PR processing#4223 — the environment: e2e-tests gate already handles this, so the /e2e comment-trigger workaround and its PR-head-ref resolution step aren't needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Fixes #
Completes the // TODO: on next PR, email verification left in signup.spec.ts, using a local SMTP mail catcher (Mailpit) instead of either hitting real Mailgun or bypassing verification, the app sends a real email, the test reads it back and clicks the real link, exactly like a real user would.
Demo:
flow-3-email.mp4
Changes:
I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #123