Skip to content

Fix feedback submissions rejected by metadata validation - #256

Open
AmanVarshney01 wants to merge 1 commit into
mainfrom
fix/feedback-flat-metadata
Open

Fix feedback submissions rejected by metadata validation#256
AmanVarshney01 wants to merge 1 commit into
mainfrom
fix/feedback-flat-metadata

Conversation

@AmanVarshney01

Copy link
Copy Markdown
Member

prisma feedback fails against the live service with HTTP 400: meta must be an object with string values. The engine migration changed the wire payload from flat nodeVersion metadata to a nested runtime object.

Restore the service-compatible metadata fields (cliVersion, nodeVersion, platform, arch) while preserving the CLI result's existing context shape. The local test server now rejects non-string metadata values, and the payload assertion checks the restored contract.

Validation:

  • pnpm typecheck and pnpm lint pass.
  • CLI tests: 964 passed, 2 platform-specific skips.
  • E2E: 6 passed, 48 credential-dependent skips.
  • Built CLI successfully submitted one user-authorized, anonymous test message to the production endpoint and returned submission ID 01a08fe1-2a2d-7000-8a55-b334e2488a5e with exit code 0.

Separate from artwork PR #253; no engine version or deployment changes.

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Essentials

Run ID: c6c5f856-23b1-4f81-9887-aa49016926ec

📥 Commits

Reviewing files that changed from the base of the PR and between 3a97d2c and fc21628.

📒 Files selected for processing (2)
  • packages/cli/src/commands/feedback.ts
  • packages/cli/tests/feedback.test.ts

Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour.


Summary by CodeRabbit

  • Bug Fixes
    • Feedback submissions now include consistent CLI version, Node.js version, platform, and architecture details.
    • Invalid feedback metadata is rejected instead of being recorded.
    • Feedback context now reports the Node.js version directly.

Walkthrough

The feedback payload now serializes cliVersion, nodeVersion, platform, and arch explicitly. The feedback test service validates that meta exists and contains only string values. Invalid metadata returns HTTP 400. The expected feedback context now uses nodeVersion.

Priority: ➖ Normal

Merge Risk: ⚪ Minimal · up to fc216

The feedback payload supplies the required metadata fields with no remaining merge-blocking issue.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly explains the metadata validation failure, the restored fields, the test changes, and the validation results.
Title check ✅ Passed The title clearly identifies the main change: fixing feedback submissions rejected by metadata validation.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/feedback-flat-metadata
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/feedback-flat-metadata

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Sep 11, 2026

Copy link
Copy Markdown

Open in StackBlitz

npx https://pkg.pr.new/@prisma/cli@256
npx https://pkg.pr.new/@prisma/cli-engine@256

commit: fc21628

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants