Skip to content

fix: Update URL comparison check - #295

Open
camdecoster wants to merge 4 commits into
mainfrom
cam/update-url-check
Open

camdecoster wants to merge 4 commits into
mainfrom
cam/update-url-check

Conversation

@camdecoster

@camdecoster camdecoster commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

Description

Update URL comparison check to better handle input URLs with no trailing slash.

Changes

  • Update check
  • Add test

Testing

Check CI.

Notes

  • We were doing an exact equality check before, and that failed when the URL didn't include the trailing slash
  • This is because Chrome normalizes the URL by adding the trailing slash

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant