Memoize PhpMethodReflection::getName() and return the right operand on a TypeCombinatorCache memo hit

[ondrejmirtes]

Two independent changes to the reflection and type-combinator hot paths.

PhpMethodReflection::getName() memo

964K calls per self-analysis run recomputed strtolower() on the same name. The result is memoized in a ?string $name field.

The matching vendored-package fixes ship as turbo-ext/poc/better-reflection-reflection-memo.patch (a new turbo-ext/poc/ directory — vendor/ is git-ignored, so a PHP fix in a vendored package cannot be committed): ReflectionFunctionAbstract::getName() memo, getAttributesByName() / filterAttributesByName() short-circuit on the attribute-less case, and the cached-member checks hoisted in front of AlreadyVisitedClasses::createEmpty(). Measured together: −1.6% user CPU on the self-analysis A/B, byte-identical output. They want a separate PR against ondrejmirtes/better-reflection; the patch file is here so the measurement can be reproduced and reviewed.

TypeCombinatorCache memo-hit identity

A memo hit handed back the result object of the call that populated the entry. When that result was one of its operands — TypeCombinator returns an operand for a union() of equal types or a remove() of nothing — the new call got the old call's operand instead of its own, and identity tests on the result flipped. ArrayType::setExistingOffsetValueType() reads union(...) === $this->itemType as "nothing was written".

Such an entry now records the operand's position in the result pointer's alignment bits (the slot stays 24 bytes) and a hit returns the operand at that position of the call at hand. One object passed at two positions leaves undecided which one a structurally equal call should return, so that call is not memoized.

The divergence is latent today: the analysis output of src/Type and src/Analyser is identical with the extension on or off either way, because the callers that test the identity are PHP and reach the operand through their own call. The four new smoke checks cover it directly at the unit level.

Verification

• turbo-ext/tests/smoke.php: fails before the fix (TCC: a memo hit returns the operand of the call at hand, TCC: a memo hit on removing nothing returns the operand of the call at hand), passes after.
• signature-parity.php (79 methods), side-by-side.php (4 classes paired): OK.
• make phpstan: no errors. make lint, make cs: clean.
• make tests with the extension loaded and active (version gate verified via bin/phpstan diagnose): 22016 tests, 97656 assertions, OK (65 skipped).

🤖 Generated with Claude Code

https://claude.ai/code/session_017MvPby652L7wUqGAHEiEcN

[staabm]

I think the poc folder was not meant to be committed?

[ondrejmirtes]

Yeah probably not, will fix 😊