Add regression tests for resource parameters of internal functions on PHP 7.4 - #6449
Merged
Merged
Conversation
… PHP 7.4 Closes phpstan/phpstan#15139 Closes phpstan/phpstan#15141 Closes phpstan/phpstan#15185 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PD8LHLdzVCovrqsR7rSsRU
This was referenced Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On PHP 7.x, PhpStorm stubs describe
resourceparameters (e.g.curl_getinfo,finfo_buffer) through#[LanguageLevelTypeAware]. BetterReflection turned that into a native type, which PHP reads back as a class namedresource, so PHPStan reported "expects resource, resource given". The BetterReflection update to 6.73.0.0 (db01588) movesresourceinto the PHPDoc instead, which fixed all three issues.This adds
CallToFunctionParametersRulePhp74Test, analysing as PHP 7.4 (phpVersion: 70400), with the playground reproducers from each issue expecting no errors.Verified: all three tests fail with BetterReflection 6.70.0.6 with the exact messages from the issues, and pass with 6.73.0.1.
Closes phpstan/phpstan#15139
Closes phpstan/phpstan#15141
Closes phpstan/phpstan#15185
🤖 Generated with Claude Code
https://claude.ai/code/session_01PD8LHLdzVCovrqsR7rSsRU