csrf verification on del actions - #1121
Merged
Merged
Conversation
TatevikGr
force-pushed
the
csrf-verification-on-del
branch
4 times, most recently
from
July 20, 2026 10:07
f8ddf9f to
781e8a0
Compare
TatevikGr
force-pushed
the
csrf-verification-on-del
branch
2 times, most recently
from
July 28, 2026 09:36
6d84f55 to
2425496
Compare
Contributor
|
I don't really understand how the exploit would work but these changes look ok. Doing a grep on the phplist source for |
Contributor
Author
SameSite=Strict seems to prevent the classic CSRF attack, but I think adding CSRF protection is still worth it as an extra layer of protection. |
Member
|
ah, I hadn't noticed this. Yes, we should add this. For now, target branch release-3.6.17 and then we can release a security update |
TatevikGr
force-pushed
the
csrf-verification-on-del
branch
from
August 9, 2026 10:43
2425496 to
3cc8c23
Compare
michield
approved these changes
Aug 9, 2026
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
#1116
#1117
Screenshots (if appropriate):