Recover transient initial object-store claims - #38
Open
igor-ladkin wants to merge 1 commit into
Open
igor-ladkin wants to merge 1 commit into
igor-ladkin wants to merge 1 commit into
Conversation
igor-ladkin
force-pushed
the
igor-ladkin/fix-object-store-initial-claim
branch
from
September 23, 2026 10:35
85b79ad to
5c30d55
Compare
chrismccord
reviewed
Sep 23, 2026
| %StoredState{meta: %Meta{} = attempted_meta}, | ||
| encoded | ||
| ) do | ||
| with {:ok, %{body: ^encoded, etag: etag}} <- |
Member
There was a problem hiding this comment.
we are pinning on ^encoded but shouldn't we be matching on our own etag instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial object-store claims fail on a single dropped connection, including when the write committed but its response was lost. Retry transient claim failures twice, then reconcile ambiguous results only when stored bytes and the complete boot owner match the attempted claim.