Rename server 'Change Password' to 'Change Server Password' (#9230) - #10035
Rename server 'Change Password' to 'Change Server Password' (#9230)#10035dpage wants to merge 2 commits into
Conversation
|
Caution Review failedAn error occurred during the review process. Please try again later. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan includes up to 8 reviews per rolling hour; 5 remain after this review. WalkthroughThe server password action and related dialog titles now use “Change Server Password.” The dialog can include the database username. Documentation distinguishes the database role password from the pgAdmin login password. ChangesServer password naming updates
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR only clarifies the server password action and related documentation; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
f73dd38 to
245aeb4
Compare
There was a problem hiding this comment.
Pull request overview
Clarifies pgAdmin’s server-node “Change Password…” action by renaming it to “Change Server Password…” and updating the dialog title to include the connected username, reducing confusion with pgAdmin account password changes.
Changes:
- Renamed the server context menu label to “Change Server Password...”.
- Updated the change-password dialog title to “Change Server Password ()” when the connected username is available.
- Added a v9.16 release note entry for the change.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| web/pgadmin/browser/server_groups/servers/static/js/server.js | Renames the menu label and updates the dialog title to include the connected username. |
| docs/en_US/release_notes_9_16.rst | Documents the UI wording change in the v9.16 bug fixes section. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| label: gettext('Change Server Password...'), priority: 10, | ||
| enable : 'is_connected',data: { | ||
| data_disabled: gettext('Please connect server to enable change password.'), | ||
| }, |
asheshv
left a comment
asheshv
left a comment
There was a problem hiding this comment.
Rename is incomplete — two user-visible places still say "Change Password":
web/pgadmin/static/js/Dialogs/index.jsx:208— the pgpass-warning alert that fires right after a successful password change still hastitle: gettext('Change Password'). The user sees the old label immediately following the action this PR is renaming.web/pgadmin/browser/server_groups/servers/static/js/server.js:131—data_disabledreadsgettext('Please connect server to enable change password.'). The disabled-state tooltip on the renamed menu still says "change password".
Note: utils.js:124 and PgAdminPermissions.py:132 reference the pgAdmin login password (user menu / admin perms), so those should stay as "Change Password" — confirming they're correctly out of scope.
Catalogs (messages.pot + per-locale .po) will need regenerating before release — matches the pattern of commit 2b20beb03. Worth either folding into this PR or noting in the release notes.
245aeb4 to
5c522be
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
…org#9230 The "Change Password" menu option and dialog on a server node was ambiguous - it changes the PostgreSQL server password, not the pgAdmin login password. Renamed the menu and dialog title to "Change Server Password" and included the connected username in the dialog title to disambiguate. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The pgpass warning that fires straight after a successful change was still titled "Change Password", so the user saw the old label in the notification immediately following the action being renamed, and the disabled-state tooltip on the menu still read "Please connect server to enable change password". Both now match the menu item. The documentation needed the same treatment: the Object menu table in menu_bar.rst still advertised "Change Password...", and the dialog's own page was titled "Change Password Dialog" whilst describing "your password" without saying which one. Since the whole point of pgadmin-org#9230 is that people were confusing this with their pgAdmin login password, the introduction now says explicitly which password it changes. The remaining "Change Password" strings in browser/js/utils.js and PgAdminPermissions.py refer to the pgAdmin login password and are correctly left alone.
5c522be to
ef55322
Compare
Summary
Fixes #9230.
The Change Password... menu option on a server node (and its dialog) is ambiguous — it changes the PostgreSQL server password, but reads as if it might change the pgAdmin login password. As discussed on the issue, this renames the menu option and dialog to Change Server Password and includes the connected username in the dialog title to make the target unmistakable.
Changes
server.js: menu labelChange Password...→Change Server Password...; dialog title →Change Server Password (<username>).🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Bug Fixes
Documentation