feat(SkeletonTable): add hasHeader prop - #973
Open
platex-rehor-bot wants to merge 1 commit into
Open
Conversation
PF-4546 Add a `hasHeader` boolean prop (default `true`) to SkeletonTable that controls whether the header skeleton row is rendered. This allows consumers to suppress header skeletons when a real table header is already displayed above the loading state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
hasHeaderboolean prop (defaulttrue) toSkeletonTablethat controls whether the header skeleton row is rendered. When set tofalse, only body skeleton rows are shown.Use case: In ansible/ansible-ui, the real table header (with column titles, sort controls, etc.) is already rendered above the loading state. Showing skeleton header rows creates a visual mismatch — users see the real header and a duplicate skeleton header simultaneously.
Closes #968
PF-4546
Changes
SkeletonTable.tsx: AddedhasHeaderprop (defaulttrue). Whenfalse,<SkeletonTableHead>is not rendered.SkeletonTable.test.tsx: Added tests verifyinghasHeader={false}suppresses<thead>and default behavior renders it.Test plan
hasHeader={false}hides<thead>element