Skip to content

[op-12578] Tooltip on Team planner not entirely visible #23975

Merged
bsatarnejad merged 3 commits into
release/17.6from
op-12578-tooltip-on-team-planner-not-entirely-visible-
Jun 30, 2026
Merged

[op-12578] Tooltip on Team planner not entirely visible #23975
bsatarnejad merged 3 commits into
release/17.6from
op-12578-tooltip-on-team-planner-not-entirely-visible-

Conversation

@bsatarnejad

Copy link
Copy Markdown
Contributor

Ticket

https://community.openproject.org/wp/OP-12578

What are you trying to accomplish?

The tooltip direction was based on the work package due date. For work packages that start on the first visible calendar day but end later, this caused the tooltip to open left into the frozen assignee column.
This changes the direction check to use the work package start date instead, so tooltips open right when the card begins at the left edge of the timeline.

Screenshots

Screenshot 2026-06-26 at 17 50 05 Screenshot 2026-06-26 at 17 49 40 Screenshot 2026-06-26 at 17 48 57

@bsatarnejad bsatarnejad self-assigned this Jun 26, 2026
@bsatarnejad bsatarnejad marked this pull request as ready for review June 26, 2026 17:14

@HDinger HDinger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current approach still has the same problem

Image

I also think, that changing to the start date is semantically wrong. The start day has no effect on where the icon (which contains the tooltip) is placed. Since the icon is placed at the end of the card, the due date is the one that determines the position. I guess, instead of changing that logic, it makes sense to show the card to the left for the first two (or even three) days of the week and catch the case that the start date is not in view

@bsatarnejad bsatarnejad force-pushed the op-12578-tooltip-on-team-planner-not-entirely-visible- branch 2 times, most recently from 16759ae to b9c3b78 Compare June 30, 2026 08:18
@github-actions

Copy link
Copy Markdown

Warning

Flaky specs

  • rspec ./spec/features/activities/work_package/activities_spec.rb[1:5:2:1]
  • rspec ./spec/features/projects/lists/filters_spec.rb[1:6:1]
🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #23975, linked for reference only):

- `rspec ./spec/features/activities/work_package/activities_spec.rb[1:5:2:1]`
- `rspec ./spec/features/projects/lists/filters_spec.rb[1:6:1]`

Treat this as a standalone task, unrelated to PR #23975. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #23975 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @bsatarnejad to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @bsatarnejad, and request a review from @bsatarnejad.
On every commit, set @bsatarnejad as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

@bsatarnejad bsatarnejad requested a review from HDinger June 30, 2026 08:48
@bsatarnejad bsatarnejad force-pushed the op-12578-tooltip-on-team-planner-not-entirely-visible- branch from b9c3b78 to 71447d7 Compare June 30, 2026 09:57
@github-actions

Copy link
Copy Markdown

Warning

Flaky specs

  • rspec ./spec/features/work_packages/new/new_work_package_spec.rb[1:1:1:3:1]
🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #23975, linked for reference only):

- `rspec ./spec/features/work_packages/new/new_work_package_spec.rb[1:1:1:3:1]`

Treat this as a standalone task, unrelated to PR #23975. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #23975 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @bsatarnejad to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @bsatarnejad, and request a review from @bsatarnejad.
On every commit, set @bsatarnejad as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

@bsatarnejad bsatarnejad merged commit 6d973fc into release/17.6 Jun 30, 2026
16 checks passed
@bsatarnejad bsatarnejad deleted the op-12578-tooltip-on-team-planner-not-entirely-visible- branch June 30, 2026 10:16
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

2 participants