Fix some HTML validation issues.#3078
Merged
Merged
Conversation
- `templates/ContentGenerator/Grades/problem_table.html.ep`: On line 40 a `th` is closed with a `td`. - `templates/HelpFiles/InstructorAchievementList.html.ep`: On line 76 a `dt` tag is closed with a `td`. - `templates/ContentGenerator/Options.html.ep`: On line 170 a `legend` is closed with a `fieldset`. - `templates/HelpFiles/InstructorScoring.html.ep`: Starting at line 18 there is a `dl` nested inside a `p` which is invalid HTML. So end the `p` tag before the `dl` is started. - `templates/ContentGenerator/Instructor/Scoring.html.ep`: The ending `dl` tag on line 96 should not be inside the for loop. This results in extraneous `dl` closings. - `templates/ContentGenerator/Base/set_status.html.ep`: A `p` tag is incorrectly created using a string instead of a proper tag on line 11. - `templates/ContentGenerator/ProblemSet.html.ep`: A `p` tag is created in a bad way on line 44. - `templates/ContentGenerator/Instructor/ProblemSetList/set_list_row.html.ep`: A `tr` tag is started on line 16 that is never ended. It should be ended at the end of the file. The last two are not strictly HTML validation issues, and do work, but they are not done in a good way.
drgrice1
force-pushed
the
html-validation-issues
branch
from
July 19, 2026 23:33
b7ec109 to
175ab06
Compare
pstaabp
approved these changes
Jul 21, 2026
somiaj
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
templates/ContentGenerator/Grades/problem_table.html.ep: On line 40 athis closed with atd.templates/HelpFiles/InstructorAchievementList.html.ep: On line 76 adttag is closed with atd.templates/ContentGenerator/Options.html.ep: On line 170 alegendis closed with afieldset.templates/HelpFiles/InstructorScoring.html.ep: Starting at line 18 there is adlnested inside apwhich is invalid HTML. So end theptag before thedlis started.templates/ContentGenerator/Instructor/Scoring.html.ep: The endingdltag on line 96 should not be inside the for loop. This results in extraneousdlclosings.templates/ContentGenerator/Base/set_status.html.ep: Aptag is incorrectly created using a string instead of a proper tag on line 11.templates/ContentGenerator/ProblemSet.html.ep: Aptag is created in a bad way on line 44.templates/ContentGenerator/Instructor/ProblemSetList/set_list_row.html.ep:A
trtag is started on line 16 that is never ended. It should beended at the end of the file.
The last two are not strictly HTML validation issues, and do work, but they are not done in a good way.