Skip to content

Pin LVMS install namespace for CO 5.0 compliance jobs - #85185

Open
yuumasato wants to merge 1 commit into
openshift:mainfrom
yuumasato:fix-co-lvms-namespace-5.0
Open

Pin LVMS install namespace for CO 5.0 compliance jobs#85185
yuumasato wants to merge 1 commit into
openshift:mainfrom
yuumasato:fix-co-lvms-namespace-5.0

Conversation

@yuumasato

@yuumasato yuumasato commented Sep 15, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

What

Explicitly set LVM_OPERATOR_SUB_INSTALL_NAMESPACE: openshift-lvm-storage on the two Compliance Operator 5.0 LVMS-backed jobs:

  • metal-ds-ipi-ovn-lvms-f14-compliance
  • metal-ds-ipi-ovn-lvms-f14-compliance-destructive

Why

Workaround for a bug in the shared operatorhub-subscribe-lvm-operator and storage-create-lvm-cluster steps (fix pending in #85087): the namespace auto-detection uses only the minor version, so for OCP 5.x (MINOR_VERSION=0) it picks openshift-storage instead of openshift-lvm-storage. The OLM subscription is created in the wrong namespace, installedCSV never populates, and LVMS installation times out.

Setting the namespace explicitly bypasses the broken auto-detection entirely — the step takes the else branch and uses the provided value directly.

Tracked in CMP-4727.

Note

This workaround can be removed once #85087 merges and the shared step is fixed.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Sets LVM_OPERATOR_SUB_INSTALL_NAMESPACE=openshift-lvm-storage for the two Compliance Operator 5.0 LVMS-backed jobs.
  • Prevents namespace auto-detection from selecting openshift-storage, which causes LVMS installation timeouts.
  • Applies to:
    • metal-ds-ipi-ovn-lvms-f14-compliance
    • metal-ds-ipi-ovn-lvms-f14-compliance-destructive
  • This workaround can be removed after the shared-step fix in #85087 merges.

@yuumasato @claude
Pin LVMS install namespace for CO 5.0 compliance jobs
9623441 
Workaround for the namespace auto-detection bug in the shared
operatorhub-subscribe-lvm-operator step (fix pending in openshift#85087):
for OCP 5.x MINOR_VERSION=0, so the step incorrectly selects
openshift-storage instead of openshift-lvm-storage, leaving the
OLM subscription permanently unresolved.

Explicitly set LVM_OPERATOR_SUB_INSTALL_NAMESPACE=openshift-lvm-storage
on metal-ds-ipi-ovn-lvms-f14-compliance[-destructive] to bypass the
broken auto-detection until the shared step is fixed.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: b25196a6-cc13-4661-9572-a4e57e72c6c2

📥 Commits

Reviewing files that changed from the base of the PR and between 5fe9ad5 and 9623441.

📒 Files selected for processing (1)
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__amd64-nightly.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.

Walkthrough

Two scheduled compliance jobs now set the LVM operator installation namespace to openshift-lvm-storage.

Changes

LVM operator namespace configuration

Layer / File(s) Summary
Compliance job environment updates
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__amd64-nightly.yaml		 The compliance and destructive compliance jobs add LVM_OPERATOR_SUB_INSTALL_NAMESPACE: openshift-lvm-storage to their environments.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: jadhaj

Merge Risk: ⚪ Minimal · up to 96234

This change directly addresses the LVMS namespace detection issue without introducing an identified merge risk.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: setting the LVMS installation namespace for CO 5.0 compliance jobs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS. The pull request changes only one YAML CI configuration file. It adds the fixed value LVM_OPERATOR_SUB_INSTALL_NAMESPACE: openshift-lvm-storage to two job environment blocks. The diff adds no …
Test Structure And Quality ✅ Passed PASS. The pull request changes one YAML ci-operator job configuration file only. The diff adds LVM_OPERATOR_SUB_INSTALL_NAMESPACE: openshift-lvm-storage to two jobs and changes no Ginkgo It blocks…
Microshift Test Compatibility ✅ Passed The pull request changes only one CI YAML file. It adds LVM_OPERATOR_SUB_INSTALL_NAMESPACE to two existing jobs and adds no Ginkgo tests or test code. The MicroShift Test Compatibility check is ther…
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS — The pull request changes one YAML configuration file and adds only two LVM_OPERATOR_SUB_INSTALL_NAMESPACE environment entries. It adds no Ginkgo tests or test code, so the SNO multi-node comp…
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The pull request changes only one CI configuration YAML file. It adds LVM_OPERATOR_SUB_INSTALL_NAMESPACE: openshift-lvm-storage to two job environment blocks. It does not add or modify deploym…
Ote Binary Stdout Contract ✅ Passed PASS: The pull request changes only one YAML CI configuration file. It adds LVM_OPERATOR_SUB_INSTALL_NAMESPACE: openshift-lvm-storage to two job environment maps. The diff contains no OTE binary sou…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: The pull request changes only one YAML CI configuration file. The diff adds LVM_OPERATOR_SUB_INSTALL_NAMESPACE: openshift-lvm-storage to two existing jobs. It adds no Ginkgo tests, IPv4-specif…
No-Weak-Crypto ✅ Passed PASS. The authoritative diff changes one YAML file and adds only two identical namespace settings: LVM_OPERATOR_SUB_INSTALL_NAMESPACE: openshift-lvm-storage. The added lines contain no MD5, SHA1, DE…
Container-Privileges ✅ Passed The pull request changes one YAML file and adds only two environment entries: LVM_OPERATOR_SUB_INSTALL_NAMESPACE: openshift-lvm-storage. The added lines do not set privileged, hostPID, `hostNetw…
No-Sensitive-Data-In-Logs ✅ Passed The pull request changes only two YAML environment mappings, both setting LVM_OPERATOR_SUB_INSTALL_NAMESPACE to the fixed value openshift-lvm-storage. The diff adds no logging, credentials, tokens…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@yuumasato: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-openshift-tests-private-release-5.0-amd64-nightly-metal-ds-ipi-ovn-lvms-f14-compliance N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-5.0-amd64-nightly-metal-ds-ipi-ovn-lvms-f14-compliance-destructive N/A periodic Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@yuumasato

yuumasato commented Sep 15, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-ci

openshift-ci Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

@yuumasato: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2026
@yuumasato

yuumasato commented Sep 15, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-ci

openshift-ci Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

@yuumasato: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

@yuumasato: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-5.0-amd64-nightly-metal-ds-ipi-ovn-lvms-f14-compliance 9623441 link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-5.0-amd64-nightly-metal-ds-ipi-ovn-lvms-f14-compliance
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-5.0-amd64-nightly-metal-ds-ipi-ovn-lvms-f14-compliance-destructive 9623441 link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-5.0-amd64-nightly-metal-ds-ipi-ovn-lvms-f14-compliance-destructive

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@yuumasato

yuumasato commented Sep 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack
Skipping it today as it is failing with private-deck@openshift-ci-private.iam.gserviceaccount.com does not have storage.objects.get access to the Google Cloud Storage object. Permission 'storage.objects.get' denied on resource

@yuumasato

yuumasato commented Sep 15, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot

openshift-merge-bot Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

@yuumasato: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 15, 2026
@taimurhafeez

taimurhafeez commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ci Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: taimurhafeez, yuumasato
Once this PR has been reviewed and has the lgtm label, please assign memodi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuumasato

yuumasato commented Sep 15, 2026

Copy link
Copy Markdown
Contributor Author

/assign memodi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@memodi memodi Awaiting requested review from memodi
@oliver-smakal oliver-smakal Awaiting requested review from oliver-smakal
1 more reviewer
@taimurhafeez taimurhafeez taimurhafeez approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@taimurhafeez taimurhafeez

@memodi memodi

Labels

lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yuumasato @taimurhafeez @memodi