Skip to content

fix(RHIDP-12941): adjust RHDH deployment timeouts - #85108

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
pmacik:fix/rhdh-timeouts
Sep 15, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
pmacik:fix/rhdh-timeouts

Conversation

@pmacik

@pmacik pmacik commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

The RHDH performance test configuration now uses 120-minute timeouts for catalog refreshes and CPT LDAP scheduling. This reduces wait times in CPT and UI performance scenarios in OpenShift CI.

@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

We couldn't safely recover the incremental review. No full review was started, and the last reviewed checkpoint was preserved. Retry later, or explicitly request a full review by commenting @coderabbitai full review.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: 3a4b5e3e-e47a-402d-8c10-4651ad9a6a43

📥 Commits

Reviewing files that changed from the base of the PR and between ddf53f0 and f21fe1f.

📒 Files selected for processing (1)
  • ci-operator/config/redhat-performance/backstage-performance/redhat-performance-backstage-performance-main.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Walkthrough

The performance test configuration changes catalog refresh intervals from 10080 to 120 minutes. CPT environments also set LDAP_SCHEDULE_TIMEOUT_MINUTES to 120.

Changes

Backstage performance schedules

Layer / File(s) Summary
CPT schedule settings
ci-operator/config/redhat-performance/backstage-performance/redhat-performance-backstage-performance-main.yaml
The CPT environments use 120-minute catalog refresh intervals and 120-minute LDAP schedule timeouts.
UI catalog refresh settings
ci-operator/config/redhat-performance/backstage-performance/redhat-performance-backstage-performance-main.yaml
The UI environments use 120-minute catalog refresh intervals.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: psalajova

Merge Risk: ⚪ Minimal · up to f21fe

The configuration changes consistently set the intended 120-minute performance intervals and timeouts, with no identified merge-blocking issue.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the timeout-related configuration changes, although it does not mention the catalog refresh interval adjustment specifically.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS. The reviewed range changes one YAML configuration file only. All 14 added lines set static timeout values ("120") for CATALOG_REFRESH_INTERVAL_MINUTES and LDAP_SCHEDULE_TIMEOUT_MINUTES. Th…
Test Structure And Quality ✅ Passed PASS: The pull request changes one YAML performance-test configuration file only. The diff updates environment values for catalog and LDAP scheduling timeouts. It contains no Ginkgo test code, It bloc…
Microshift Test Compatibility ✅ Passed The check is not applicable. The pull request changes only one YAML performance configuration file. It adds or updates environment variables such as CATALOG_REFRESH_INTERVAL_MINUTES and `LDAP_SCHEDU…
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The pull request changes only one YAML performance configuration file. The diff updates environment values and adds LDAP timeout values; it adds no Ginkgo e2e tests or test declarations. Therefo…
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The pull request changes only one CI test configuration file. The diff changes CATALOG_REFRESH_INTERVAL_MINUTES values and adds LDAP_SCHEDULE_TIMEOUT_MINUTES; it does not add or modify deplo…
Ote Binary Stdout Contract ✅ Passed PASS. The reviewed range changes only one YAML performance configuration file. It replaces environment values and adds LDAP_SCHEDULE_TIMEOUT_MINUTES; it adds no main, init, TestMain, Ginkgo su…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS — The pull request changes one YAML configuration file only. The diff updates performance-test environment values and adds no Ginkgo test code, IPv4 literals, IP parsing, network policies, or ext…
No-Weak-Crypto ✅ Passed PASS: The pull request changes only one YAML performance-test configuration. Added values are CATALOG_REFRESH_INTERVAL_MINUTES: "120" and LDAP_SCHEDULE_TIMEOUT_MINUTES: "120". The complete added-l…
Container-Privileges ✅ Passed The pull request changes only CI performance-test environment values: CATALOG_REFRESH_INTERVAL_MINUTES and LDAP_SCHEDULE_TIMEOUT_MINUTES. The changed file and added patch lines contain no `privile…
No-Sensitive-Data-In-Logs ✅ Passed The pull request changes one YAML configuration file. The added values are numeric timeout settings: CATALOG_REFRESH_INTERVAL_MINUTES: "120" and LDAP_SCHEDULE_TIMEOUT_MINUTES: "120". The diff adds…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2026
Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
@openshift-ci

openshift-ci Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@pmacik: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-redhat-performance-backstage-performance-main-ui-baseline redhat-performance/backstage-performance presubmit Ci-operator config changed
pull-ci-redhat-performance-backstage-performance-main-ui-dynamic-plugins redhat-performance/backstage-performance presubmit Ci-operator config changed
periodic-ci-redhat-performance-backstage-performance-main-ui-cpt-m N/A periodic Ci-operator config changed
periodic-ci-redhat-performance-backstage-performance-main-mvp-cpt-l N/A periodic Ci-operator config changed
periodic-ci-redhat-performance-backstage-performance-main-mvp-cpt-m N/A periodic Ci-operator config changed
periodic-ci-redhat-performance-backstage-performance-main-mvp-cpt-s N/A periodic Ci-operator config changed
periodic-ci-redhat-performance-backstage-performance-main-mvp-cpt-xl N/A periodic Ci-operator config changed
periodic-ci-redhat-performance-backstage-performance-main-mvp-cpt-xs N/A periodic Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2026
@openshift-ci

openshift-ci Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pmacik, shashankkestwal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pmacik

pmacik commented Sep 15, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-ci

openshift-ci Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

@pmacik: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 15, 2026
@openshift-ci

openshift-ci Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

@pmacik: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit ffbe638 into openshift:main Sep 15, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants